Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(canary): sort dataplaneId parameter on BeatProducer #1206

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(canary): sort dataplaneId parameter on BeatProducer #1206

merged 1 commit into from
Dec 17, 2024

Conversation

mijailr
Copy link
Contributor

@mijailr mijailr commented Dec 17, 2024

The change corrects the order of parameters in the initialize method to ensure canaryConfig.getMetronomeServerDataplaneId() is correctly placed after canaryConfig.getMetronomeServerId().

@mijailr mijailr added the server Affects the core LH Server code. label Dec 17, 2024
@mijailr mijailr requested a review from sauljabin December 17, 2024 16:23
@mijailr mijailr self-assigned this Dec 17, 2024
@sauljabin sauljabin merged commit b4bd009 into master Dec 17, 2024
16 checks passed
@sauljabin sauljabin deleted the fix/canary-cluster-id branch December 17, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauljabin sauljabin sauljabin approved these changes

Assignees

@mijailr mijailr

Labels
server Affects the core LH Server code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mijailr @sauljabin