remove enableBackupCodec for VideoPublishOptions.

livekit · Dec 12, 2023 · e1be6af · e1be6af
1 parent 7114399
commit e1be6af
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/example/lib/pages/connect.dart b/example/lib/pages/connect.dart
@@ -142,7 +142,7 @@ class _ConnectPageState extends State<ConnectPage> {
         preferredCodec = _preferredCodec;
       }
 
-      bool enableBackUpCodec = ['VP9', 'AV1'].contains(preferredCodec);
+      bool enableBackupVideoCodec = ['VP9', 'AV1'].contains(preferredCodec);
 
       // create new room
       final room = Room(
@@ -155,7 +155,7 @@ class _ConnectPageState extends State<ConnectPage> {
         defaultVideoPublishOptions: VideoPublishOptions(
           simulcast: _simulcast,
           videoCodec: preferredCodec,
-          enableBackupCodec: enableBackUpCodec,
+          backupVideoCodec: enableBackupVideoCodec ? BackupVideoCodec() : null,
         ),
         defaultScreenShareCaptureOptions: const ScreenShareCaptureOptions(
             useiOSBroadcastExtension: true,

diff --git a/lib/src/options.dart b/lib/src/options.dart
@@ -201,8 +201,6 @@ class VideoPublishOptions {
 
   final String? scalabilityMode;
 
-  final bool enableBackupCodec;
-
   final BackupVideoCodec? backupVideoCodec;
 
   const VideoPublishOptions({
@@ -212,7 +210,6 @@ class VideoPublishOptions {
     this.videoSimulcastLayers = const [],
     this.screenShareSimulcastLayers = const [],
     this.name,
-    this.enableBackupCodec = true,
     this.backupVideoCodec,
     this.scalabilityMode,
   });
@@ -223,7 +220,6 @@ class VideoPublishOptions {
     List<VideoParameters>? videoSimulcastLayers,
     List<VideoParameters>? screenShareSimulcastLayers,
     String? videoCodec,
-    bool? enableBackupCodec,
     BackupVideoCodec? backupVideoCodec,
     String? scalabilityMode,
   }) =>
@@ -234,7 +230,6 @@ class VideoPublishOptions {
         screenShareSimulcastLayers:
             screenShareSimulcastLayers ?? this.screenShareSimulcastLayers,
         videoCodec: videoCodec ?? this.videoCodec,
-        enableBackupCodec: enableBackupCodec ?? this.enableBackupCodec,
         backupVideoCodec: backupVideoCodec ?? this.backupVideoCodec,
         scalabilityMode: scalabilityMode ?? this.scalabilityMode,
       );

diff --git a/lib/src/participant/local.dart b/lib/src/participant/local.dart
@@ -210,12 +210,7 @@ class LocalParticipant extends Participant<LocalTrackPublication> {
       ),
     ];
 
-    if (publishOptions.enableBackupCodec == true &&
-        publishOptions.backupVideoCodec == null) {
-      publishOptions.copyWith(backupVideoCodec: BackupVideoCodec());
-    }
-
-    if (publishOptions.enableBackupCodec == true &&
+    if (publishOptions.backupVideoCodec != null &&
         publishOptions.backupVideoCodec!.codec != publishOptions.videoCodec) {
       simulcastCodecs.add(lk_rtc.SimulcastCodec(
         codec: publishOptions.backupVideoCodec!.codec.toLowerCase(),