Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use getSettings() to get actual dimensions for mobile #560

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

davidliu
Copy link
Contributor

@davidliu davidliu commented Jul 22, 2024

Requires flutter-webrtc/flutter-webrtc#1636 to get actual dimensions.

Addresses webrtc-sdk/webrtc#133

@davidliu davidliu requested a review from cloudwebrtc July 22, 2024 06:43
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@davidliu davidliu merged commit 76973a3 into main Jul 22, 2024
8 checks passed
@davidliu davidliu deleted the dl/mobile_encodings branch July 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants