-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media tracks with start_time not handled correctly #403
Comments
Thanks @victorges! To expand on this bit:
The Mist are currently working on a "trigger" for failures, which would allow us to rely to that rather than this mechanism for determining success/failure. |
Yeah, Thom's suggestion sounds good to me. Technically none of all that is "wrong", after all - it's just the check is confused by the difference in duration. 🙃 |
Files changed: M manifest.yaml Co-authored-by: livepeer-docker <[email protected]>
@thomshutt was this fixed? the referencing commit looks weird, don't think it is related to this |
@victorges nope sorry - I mass closed old issues since a lot of them were related to the Mist-based VOD pipeline but if any (like this one) are still relevant then feel free to reopen |
All the VOD pipelines that we have built today (including the old non-catalyst one) fail consistently when the video has tracks with offset start_times.
These params can happen naturally when clipping the video, as ffmpeg for example will prefer to keep the whole segment intact and just shift playback through start_time than to actually re-transcode the segment. Even though, it is not that common for videos to have a start_time. There's an alert everytime someone uploads a video with a considerable one (>250ms i think) and it doesn't happen that often.
These videos play fine on any player I tried, but get (consistent) glitches anytime they're uploaded to our platform. The current behaviors are:
error="input video duration (63800ms) does not match segmented video duration (66944ms)"
A test file is: https://lp-playback.com/hls/63d0be6pfau46m1s/video
I don't think this is a super urgent bug, but we should keep this in mind when we change to mediaconvert fallback logic. We should process the start_time property of the videos and skip directly to MediaConvert pipeline if the video does have one.
The fix in MediaConvert is likely trivial tho, probably just some additional config. For mist pipeline not sure, as I believe that error comes from the only way we have to check whether segmenting worked or not (as per Thom).
The text was updated successfully, but these errors were encountered: