Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Benchmarking to parse and merge calls of Document. #102

Closed
simlay opened this issue May 7, 2024 · 1 comment
Closed

Add Benchmarking to parse and merge calls of Document. #102

simlay opened this issue May 7, 2024 · 1 comment

Comments

@simlay
Copy link
Contributor

simlay commented May 7, 2024

In #61, the Document shared across the FFI went from a *mut Document to a Arc<Mutex<Document>>. There's bound to be runtime overhead and we need to have a way to track the benchmarking of:
Document::parse and Document::parse_fragment_json.

It might be worth doing from Swift or Kotlin via the uniffi bindings but a good start is with cargo bench via criterion or something.

Device specific benchmarking would be cool but sonos/dinghy#81 might be a blocker.

@simlay
Copy link
Contributor Author

simlay commented May 22, 2024

Closed in #104.

@simlay simlay closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant