fix #34 should classify mp3 as audio

livingbio · Oct 11, 2023 · b4cf745 · b4cf745
1 parent 1cee6c1
commit b4cf745
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/ffmpeg_media_type/info.py b/src/ffmpeg_media_type/info.py
@@ -104,7 +104,7 @@ def _guess_media_info(
 
     for stream in info.streams:
         # NOTE: if there is at least one video stream, the media is video
-        if stream.codec_type == "video":
+        if stream.codec_type == "video" and format_name not in ("mp3", ):
             width = stream.width
             height = stream.height
 

diff --git a/src/ffmpeg_media_type/tests/__snapshots__/6.0/test_info.ambr b/src/ffmpeg_media_type/tests/__snapshots__/6.0/test_info.ambr
@@ -120,6 +120,17 @@
     'width': 1280,
   })
 # ---
+# name: test_detect[mp3-with-cover.mp3][mp3-with-cover.mp3]
+  dict({
+    'duration': 1.044898,
+    'format': 'mp3',
+    'height': 0,
+    'size': 677673,
+    'suggest_ext': 'mp3',
+    'type': 'audio',
+    'width': 0,
+  })
+# ---
 # name: test_detect[overlay.png][overlay.png]
   dict({
     'duration': 0.0,

diff --git a/src/ffmpeg_media_type/utils/tests/test_ffmpeg/mp3-with-cover.mp3 b/src/ffmpeg_media_type/utils/tests/test_ffmpeg/mp3-with-cover.mp3