Update golangci-lint version and fix reports

This commit updates golangci-lint to v1.44.0. It also removes deprecated golint in favour of revive linter. Finally, it addresses an issue reported by linter. Signed-off-by: Milos Gajdos <[email protected]>
lizMSFT · Jan 28, 2022 · ebd3f44 · ebd3f44
1 parent be4c921
commit ebd3f44
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -6,7 +6,7 @@ linters:
     - unconvert
     - gofmt
     - goimports
-    - golint
+    - revive
     - ineffassign
     - vet
     - unused

diff --git a/context/http.go b/context/http.go
@@ -246,9 +246,7 @@ func (ctx *muxVarsContext) Value(key interface{}) interface{} {
 			return ctx.vars
 		}
 
-		if strings.HasPrefix(keyStr, "vars.") {
-			keyStr = strings.TrimPrefix(keyStr, "vars.")
-		}
+		keyStr = strings.TrimPrefix(keyStr, "vars.")
 
 		if v, ok := ctx.vars[keyStr]; ok {
 			return v

diff --git a/script/setup/install-dev-tools b/script/setup/install-dev-tools
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-GOLANGCI_LINT_VERSION="v1.27.0"
+GOLANGCI_LINT_VERSION="v1.44.0"
 
 #
 # Install developer tools to $GOBIN (or $GOPATH/bin if unset)
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,7 +6,7 @@ linters: @@
         - unconvert
         - gofmt
         - goimports
-        - golint
+        - revive
         - ineffassign
         - vet
         - unused
@@ Expand Down @@