From a02b93c7fe78d20d12c9f5572f54651f3f8b57ff Mon Sep 17 00:00:00 2001 From: Luke Kingland Date: Thu, 4 Apr 2024 16:08:34 +0900 Subject: [PATCH] update oci builder to respect FUNC_GO --- pkg/oci/containerize_go.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/oci/containerize_go.go b/pkg/oci/containerize_go.go index 8dce2ac884..0d78d8bef2 100644 --- a/pkg/oci/containerize_go.go +++ b/pkg/oci/containerize_go.go @@ -102,8 +102,13 @@ func goBuildCmd(p v1.Platform, cfg *buildConfig) (gobin string, args []string, o * Either replace or append to gobin */ - // Use the binary specified FUNC_GO_PATH if defined - gobin = os.Getenv("FUNC_GO_PATH") // TODO: move to main and plumb through + // FIXME: the FUNC_GO environment variable should be + // pulled out into "cmd", and this setting plumbed through + // either as an argument or context variable accessed here, rather + // than accessing the environment variables directly from within a + // library. This is temporary for purposes of the E2E update and + // will be completed in a separate issue. Issue #TBD + gobin = os.Getenv("FUNC_GO") if gobin == "" { gobin = "go" }