Optimize list append

myframe/common.h

@@ -31,13 +31,6 @@ class MYFRAME_EXPORT Common final {
   static stdfs::path GetAbsolutePath(const std::string& flag_path);
   static bool IsAbsolutePath(const std::string& path);
 
-  template <typename T>
-  static void ListAppend(
-    std::list<std::shared_ptr<T>>* dst,
-    std::list<std::shared_ptr<T>>* src) {
-    dst->insert(dst->end(), src->begin(), src->end());
-    src->clear();
-  }
   static std::vector<std::string> SplitMsgName(const std::string& name);
 };
 

myframe/mailbox.cpp

@@ -5,7 +5,6 @@ All rights reserved.
 Author: 李柯鹏 <[email protected]>
 ****************************************************************************/
 #include "myframe/mailbox.h"
-#include "myframe/common.h"
 #include "myframe/msg.h"
 
 namespace myframe {
@@ -51,7 +50,7 @@ void Mailbox::Send(
 }
 
 void Mailbox::Send(std::list<std::shared_ptr<Msg>>* msg_list) {
-  Common::ListAppend(&send_, msg_list);
+  send_.splice(send_.end(), *msg_list);
 }
 
 std::list<std::shared_ptr<Msg>>* Mailbox::GetSendList() {
@@ -75,7 +74,7 @@ void Mailbox::Recv(std::shared_ptr<Msg> msg) {
 }
 
 void Mailbox::Recv(std::list<std::shared_ptr<Msg>>* msg_list) {
-  Common::ListAppend(&recv_, msg_list);
+  recv_.splice(recv_.end(), *msg_list);
 }
 
 const std::shared_ptr<const Msg> Mailbox::PopRecv() {

myframe/worker_context.cpp

@@ -9,7 +9,6 @@ Author: 李柯鹏 <[email protected]>
 #include <functional>
 
 #include "myframe/log.h"
-#include "myframe/common.h"
 #include "myframe/msg.h"
 #include "myframe/worker.h"
 #include "myframe/app.h"
@@ -90,7 +89,7 @@ void WorkerContext::Cache(std::shared_ptr<Msg> msg) {
 }
 
 void WorkerContext::Cache(std::list<std::shared_ptr<Msg>>* msg_list) {
-  Common::ListAppend(&cache_, msg_list);
+  cache_.splice(cache_.end(), *msg_list);
 }
 
 Mailbox* WorkerContext::GetMailbox() {