Merge pull request #87 from ll7/85-Read-video-fps-from-env-config

Read video fps from env config

robot_sf/gym_env/robot_env.py

@@ -56,7 +56,7 @@ def __init__(
         recording_enabled: bool = False,
         record_video: bool = False,
         video_path: str = None,
-        video_fps: int = 10,  # TODO: Read from env settings
+        video_fps: float = None,
         peds_have_obstacle_forces: bool = False,
     ):
         """
@@ -76,6 +76,11 @@ def __init__(
         # Environment configuration details
         self.env_config = env_config
 
+        # Set video FPS if not provided
+        if video_fps is None:
+            video_fps = 1/self.env_config.sim_config.time_per_step_in_secs
+            logger.info(f"Video FPS not provided, setting to {video_fps}")
+
         # Extract first map definition; currently only supports using the first map
         self.map_def = env_config.map_pool.choose_random_map()
 

robot_sf/render/sim_view.py

@@ -96,7 +96,7 @@ class SimulationView:
     focus_on_ego_ped: bool = False
     record_video: bool = False
     video_path: str = None
-    video_fps: int = 10
+    video_fps: float = 10.0
     frames: List[np.ndarray] = field(default_factory=list)
 
     # Add UI state fields

tests/test_video_recording.py

@@ -39,8 +39,7 @@ def test_video_recording(
         debug=True,
         recording_enabled=True,
         record_video=True,
-        video_path=str(video_path),
-        video_fps=int(1 / env_config.sim_config.time_per_step_in_secs),
+        video_path=str(video_path)
     )
 
     try: