From b4b33e771371ccb8f82ee73a7b379731f1d39b33 Mon Sep 17 00:00:00 2001 From: ll7 <32880741+ll7@users.noreply.github.com> Date: Fri, 6 Dec 2024 14:27:06 +0100 Subject: [PATCH 1/2] refactor: remove outdated TODO comment in PedestrianEnv class --- robot_sf/gym_env/pedestrian_env.py | 1 - 1 file changed, 1 deletion(-) diff --git a/robot_sf/gym_env/pedestrian_env.py b/robot_sf/gym_env/pedestrian_env.py index 3de32be..72c1617 100644 --- a/robot_sf/gym_env/pedestrian_env.py +++ b/robot_sf/gym_env/pedestrian_env.py @@ -324,7 +324,6 @@ def save_recording(self, filename: str = None): # only save if there are recorded states if len(self.recorded_states) == 0: logger.warning("No states recorded, skipping save") - # TODO: First env.reset will always have no recorded states return os.makedirs(os.path.dirname(filename), exist_ok=True) From 06f479e3c3dfb158a6804d8283533df745b864a3 Mon Sep 17 00:00:00 2001 From: ll7 <32880741+ll7@users.noreply.github.com> Date: Fri, 6 Dec 2024 14:27:28 +0100 Subject: [PATCH 2/2] feat: enable focus on robot in SimulationView by default --- robot_sf/render/sim_view.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/robot_sf/render/sim_view.py b/robot_sf/render/sim_view.py index 691d22d..606d974 100644 --- a/robot_sf/render/sim_view.py +++ b/robot_sf/render/sim_view.py @@ -92,7 +92,7 @@ class SimulationView: map_def: MapDefinition = field(default_factory=MapDefinition) obstacles: List[Obstacle] = field(default_factory=list) caption: str = "RobotSF Simulation" - focus_on_robot: bool = False + focus_on_robot: bool = True focus_on_ego_ped: bool = False record_video: bool = False video_path: str = None