New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert S3 client C code into C++ #11

Open

llewelld opened this issue Jun 23, 2020 · 5 comments

Owner

llewelld commented Jun 23, 2020

The S3 client access code needs cleaning up and converting from C to C++.

Thaodan commented Jun 24, 2020

See #21

Thaodan commented Jun 24, 2020 •

edited

Loading

This also could remove the libxml2 dependency.

Thaodan commented Jun 24, 2020

Methods that need to be replaced (in order of dependency):

s3_free(m_s3);
s3_hmac_sign()
s3_init()
s3_bucket_entries_free(entries);

Structs:

struct s3_bucket_entry_head *entries;
struct s3_bucket_entry_head

Used this to check for uses of s3c code:

cd src
for to_replace in \
    s3_bucket_entry \
        s3_init \
        s3_free \
        s3_string \
        s3_string_init \
        s3_string_curl_writefunc \
        s3_string_curl_readfunc\
        s3_string_free\
        s3_hmac_sign\
        s3_md5_sum\
        s3_get\
        s3_delete\
        s3_put\
        s3_bucket_entry_free \
        s3_bucket_entries_free\
        s3_bucket_entry_head
        do
    grep -H $to_replace -- *
done

Thaodan commented Jun 25, 2020

For s3_hmac_sign(): https://docs.aws.amazon.com/AmazonSimpleDB/latest/DeveloperGuide/HMACAuth.html

Thaodan commented Jun 28, 2020

This Wiki page gives the hint we could replace this with an Qt function replacing the need to work directly with OpenSSL code.

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Replace s3_hmac_sign() with HMAC() from OpenSSL

72b2317

Instead of using s3_hmac_sign() which does everything on its own
resuse HMAC() from OpenSSL. This adds some casting that was done
previously inside s3_hmac_sign() to performOp().
In addition we no longer use the deprecated HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len,
               const EVP_MD *md) (<1.1).

Removes the usage of:
+ s3_hmac_sign()

Contributes to llewelld#11

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Refactor out the usage of the S3 struct

dc302d5

The S3 struct is no longer used since all c-style s3 methods are no
longer used.
Remove all code that related to it.

Removes the usage of:
+ s3_free()
+ s3_init()

Contributes to llewelld#11.

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Replace s3_hmac_sign() with HMAC() from OpenSSL

bd99061

Instead of using s3_hmac_sign() which does everything on its own
resuse HMAC() from OpenSSL. This adds some casting that was done
previously inside s3_hmac_sign() to performOp().
In addition we no longer use the deprecated HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len,
               const EVP_MD *md) (<1.1).

Removes the usage of:
+ s3_hmac_sign()

Contributes to llewelld#11

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Refactor out the usage of the S3 struct

0669e59

The S3 struct is no longer used since all c-style s3 methods are no
longer used.
Remove all code that related to it.

Removes the usage of:
+ s3_free()
+ s3_init()

Contributes to llewelld#11.

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Replace s3_hmac_sign() with HMAC() from OpenSSL

6f55563

Instead of using s3_hmac_sign() which does everything on its own
resuse HMAC() from OpenSSL. This adds some casting that was done
previously inside s3_hmac_sign() to performOp().
In addition we no longer use the deprecated HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len,
               const EVP_MD *md) (<1.1).

Removes the usage of:
+ s3_hmac_sign()

Contributes to llewelld#11

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Refactor out the usage of the S3 struct

d8b4b90

The S3 struct is no longer used since all c-style s3 methods are no
longer used.
Remove all code that related to it.

Removes the usage of:
+ s3_free()
+ s3_init()

Contributes to llewelld#11.

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Replace s3_hmac_sign() with HMAC() from OpenSSL

991fe5f

Instead of using s3_hmac_sign() which does everything on its own
resuse HMAC() from OpenSSL. This adds some casting that was done
previously inside s3_hmac_sign() to performOp().
In addition we no longer use the deprecated HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len,
               const EVP_MD *md) (<1.1).

Removes the usage of:
+ s3_hmac_sign()

Contributes to llewelld#11

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Refactor out the usage of the S3 struct

ead11c8

The S3 struct is no longer used since all c-style s3 methods are no
longer used.
Remove all code that related to it.

Removes the usage of:
+ s3_free()
+ s3_init()

Contributes to llewelld#11.

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Replace s3_hmac_sign() with HMAC() from OpenSSL

43bc69e

Instead of using s3_hmac_sign() which does everything on its own
resuse HMAC() from OpenSSL. This adds some casting that was done
previously inside s3_hmac_sign() to performOp().
In addition we no longer use the deprecated HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len,
               const EVP_MD *md) (<1.1).

Removes the usage of:
+ s3_hmac_sign()

Contributes to llewelld#11

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Refactor out the usage of the S3 struct

d8a173f

The S3 struct is no longer used since all c-style s3 methods are no
longer used.
Remove all code that related to it.

Removes the usage of:
+ s3_free()
+ s3_init()

Contributes to llewelld#11.

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Replace s3_hmac_sign() with HMAC() from OpenSSL

ebefcec

Instead of using s3_hmac_sign() which does everything on its own
resuse HMAC() from OpenSSL. This adds some casting that was done
previously inside s3_hmac_sign() to performOp().
In addition we no longer use the deprecated HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len,
               const EVP_MD *md) (<1.1).

Removes the usage of:
+ s3_hmac_sign()

Contributes to llewelld#11

Thaodan added a commit to Thaodan/harbour-contrac that referenced this issue


          Refactor out the usage of the S3 struct

b31c594

The S3 struct is no longer used since all c-style s3 methods are no
longer used.
Remove all code that related to it.

Removes the usage of:
+ s3_free()
+ s3_init()

Contributes to llewelld#11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment