More test fixes #11
Merged
More test fixes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable shift generates both left and right shifts and then uses select IR instruction to chose between them. Test only tries to verify compare and select instructions but trips on three more instructions in between. Trying to verify those three instructions is redundant and somewhat fragile, so it is better to change CHECK-NEEXT directive to CHECK.
Fixes test failure in CodeGen/core.f95. EmitRuntimeCall does not produce arguments, which triggers a debug assert in LLVM when generating code for STOP statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bitops test, closes #7
Variable shift generates both left and right shifts and then uses select IR instruction to chose between them. Test only tries to verify compare and select instructions but trips on three more instructions in between. Trying to verify those three instructions is redundant and somewhat fragile, so it is better to change CHECK-NEEXT directive to CHECK.
Change EmitRuntimeCall to EmitCall for STOP statement, closes #8
EmitRuntimeCall does not produce arguments, which triggers a debug assert in LLVM when generating code for STOP statement.