-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DirectX] Shader Flag Analysis to indicate use of Raw and Structured Buffers #112273
Comments
ComputeShadersPlusRawAndStructuredBuffers
This issue is blocked at the moment by the need to generate proper IR for tests. ResourceKinds are not being picked up correctly for RWBuffer or StructuredBuffer. |
Not blocked |
Closing this issue as these flags being set are no longer needed or used. The PR created to set the flags has been closed out as well and not merged. Tex opened microsoft/DirectXShaderCompiler#7003 to track addressing what to do with them long term. |
I opened #122663 the other day, which seems to be a duplicate. We should discuss whether this is really "not needed" |
Two flags viz.,
ComputeShadersPlusRawAndStructuredBuffers
andEnableRawAndStructuredBuffers
are set based on use of raw and structured buffers.EnableRawAndStructuredBuffers
if shader uses Raw or Structured buffers.ComputeShadersPlusRawAndStructuredBuffers
if shader uses Raw or Structured buffers, SM Major is = 4 and is a compute shaderNOTE:
EnableRawAndStructuredBuffers
is required for particle life butComputeShadersPlusRawAndStructuredBuffers
depends on one extra condition and can be implemented alongside.See DxilModule::CollectShaderFlagsForModule(ShaderFlags &Flags) - specifically setting of
bool hasRawAndStructuredBuffer
for the conditions to set the flagComputeShadersPlusRawAndStructuredBuffers
andEnableRawAndStructuredBuffers
.AC
Add tests that use Raw and Structure buffers to verify that the flags are appropriately set.
The text was updated successfully, but these errors were encountered: