Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc] delete old hdrgen #117208

Open
nickdesaulniers opened this issue Nov 21, 2024 · 2 comments · May be fixed by #117220
Open

[libc] delete old hdrgen #117208

nickdesaulniers opened this issue Nov 21, 2024 · 2 comments · May be fixed by #117220
Assignees
@nickdesaulniers
Labels
libc

Comments

@nickdesaulniers
Copy link
Member

Now that we have newhdrgen, filing a bug to track the removal of the existing hdrgen (couldn't find an existing bug for this; feel free to dupe this to that if it exists).

I've moved over the buildbots to use newhdrgen (required resetting buildbot's cmakecache).

cc @petrhosek @RoseZhang03 @aaryanshukla
@llvmbot
Copy link
Member

llvmbot commented Nov 21, 2024

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Now that we have newhdrgen, filing a bug to track the removal of the existing hdrgen (couldn't find an existing bug for this; feel free to dupe this to that if it exists).

I've moved over the buildbots to use newhdrgen (required resetting buildbot's cmakecache).

cc @petrhosek @RoseZhang03 @aaryanshukla

@nickdesaulniers nickdesaulniers mentioned this issue Nov 21, 2024
Closed
@aaryanshukla
Copy link
Contributor

Fairly sure no such bug existed before. Let me know if there are any issues with newhdrgen while moving the buildbots.

@nickdesaulniers nickdesaulniers linked a pull request Nov 21, 2024 that will close this issue
Open
nickdesaulniers added a commit to nickdesaulniers/llvm-project that referenced this issue Nov 21, 2024
@nickdesaulniers
[libc] delete hdrgen
3cbf6d0 
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of
@michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a
dependency on TableGen and thus LLVM in order to start bootstrapping a full
build.

This PR:
- Removes being able to set `LIBC_HDRGEN_EXE`.
- LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used.
- LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option.
- LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old
  hdrgen.
- libc-api-test and libc-api-test-tidy build targets.
- Deletes all .td files.

It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR
for that.

Link: llvm#117209
Fixes: llvm#117208
nickdesaulniers added a commit to nickdesaulniers/llvm-project that referenced this issue Nov 21, 2024
@nickdesaulniers
[libc] delete hdrgen
9e0e0ab 
Thanks to the effort of @RoseZhang03 and @aaryanshukla under the guidance of
@michaelrj-google and @amykhuang, we now have newhdrgen and no longer have a
dependency on TableGen and thus LLVM in order to start bootstrapping a full
build.

This PR removes:
- LIBC_HDRGEN_EXE; the in tree newhdrgen is the only hdrgen that can be used.
- LIBC_USE_NEW_HEADER_GEN; newhdrgen is the default and only option.
- LIBC_HDRGEN_ONLY; there is no need to have a distinct build step for old
  hdrgen.
- libc-api-test and libc-api-test-tidy build targets.
- Deletes all .td files.

It does not rename newhdrgen to just hdrgen. Will follow up with a distinct PR
for that.

Link: llvm#117209
Fixes: llvm#117208
@nickdesaulniers nickdesaulniers self-assigned this Nov 21, 2024
@nickdesaulniers nickdesaulniers mentioned this issue Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickdesaulniers nickdesaulniers

Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc] delete hdrgen nickdesaulniers/llvm-project
3 participants
@nickdesaulniers @aaryanshukla @llvmbot