Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation typo in DestinationStyleOpInterface #117222

Open
PerMildner opened this issue Nov 21, 2024 · 2 comments
Open

Documentation typo in DestinationStyleOpInterface #117222

PerMildner opened this issue Nov 21, 2024 · 2 comments

Comments

@PerMildner
Copy link

Says

    /// Return the number of DPS inits.
    int64_t getNumDpsInputs() {
      return $_op->getNumOperands() - $_op.getNumDpsInits();
    }

but it should say ... DPS inputs.

It looks like a copy-paste bug from getNumDpsInits()).

@llvmbot
Copy link
Member

llvmbot commented Nov 21, 2024

@llvm/issue-subscribers-mlir

Author: None (PerMildner)

https://github.com/llvm/llvm-project/blob/505e049aa078c8961f00cacefc3983398a46fb04/mlir/include/mlir/Interfaces/DestinationStyleOpInterface.td#L86

Says

    /// Return the number of DPS inits.
    int64_t getNumDpsInputs() {
      return $_op->getNumOperands() - $_op.getNumDpsInits();
    }

but it should say ... DPS inputs.

It looks like a copy-paste bug from getNumDpsInits()).

@CoTinker
Copy link
Contributor

Nice catch, please fell free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants