[TorchToLinalg] Fix AtenReflectionPad2dOp lowering to not assert when dimensions unknown #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjgarvey
requested changes
Nov 8, 2024
|
@zjgarvey I just added a dynamic test, it seems to work fine! I also took the chance to add dynamic asserts. |
I struggle to understand the CI error. It seems like when exporting to onnx it interprets the input sizes as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asserts make the compiler crash (with a misleading error) also when vertical or horizontal dimensions are unknown (which is a valid state at this stage).
Add dynamic asserts when dimensions are not known.