Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement and refine minimap #142

Open
2 of 6 tasks
552020 opened this issue Feb 10, 2024 · 9 comments
Open
2 of 6 tasks

implement and refine minimap #142

552020 opened this issue Feb 10, 2024 · 9 comments
Assignees
Labels

Comments

@552020
Copy link
Collaborator

552020 commented Feb 10, 2024

  • implement minimap

Extras:

  • FOV
  • add button to switch on/off the minimap
  • only part of the minimap is displayed
  • color player and ray
  • position and size minimap
@552020 552020 self-assigned this Feb 10, 2024
@lmangall
Copy link
Owner

The fact that I can tick a box in your message is as mindblowing as our missing on/off button for the minimap

@552020
Copy link
Collaborator Author

552020 commented Feb 12, 2024

It is a shocking as the fact that we can edit each other messages. Is the minimap fully implemented now? I don't think so. Or is it?

@lmangall
Copy link
Owner

Not fully (mostly the field of view representation is missing), but if it still compiles (I may have messed it up just now) I would say we merge, and then open other issues for what is left to do (so we keep one issue per implementation/bug)

@lmangall
Copy link
Owner

If we consider the field of view and rays representation of our player as optionnal, then we can consider the minimap fully implemented

@552020
Copy link
Collaborator Author

552020 commented Feb 12, 2024

  • field of view and ray are optional
  • what would not be optional to make it meaningful would be showing the direction in which the player is going: causer or you let the map rotate, the way the player is rotating so that up means always going north or you need to show the direction the player is going.
  • I still need to check your last implementation but my idea was also to show only a part of the map in the minimap, cause otherwise with big maps it will not be understandable at all. But as I said I need first to check the changes in the last PR, maybe you already implemente that.

@lmangall
Copy link
Owner

the direction in which the player is going is implemented in the branch I was working on yesterday (one green ray)

I still need to check your last implementation but my idea was also to show only a part of the map in the minimap, cause otherwise with big maps it will not be understandable at all. But as I said I need first to check the changes in the last PR, maybe you already implemente that.

Sounds good

@552020 552020 added the bonus label Feb 13, 2024
@552020 552020 changed the title implement minimap implement and refine minimap Feb 13, 2024
@lmangall
Copy link
Owner

I believe this has been done, I am closing the issue

@552020
Copy link
Collaborator Author

552020 commented Feb 17, 2024

I'm reopening it. 5/6 tasks have been reached. We have a map that is enough to get the bonus but it still kind of sucks. So maybe you can open another issue with all the 'extra' improvements that are not strictly needed to get the bonus point (so with super low priority regarding the eval).

@552020 552020 reopened this Feb 17, 2024
@lmangall
Copy link
Owner

I ticked color player and ray
Since we already have this issue here, let's just open the subisses if we decide to give a try to a particular one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants