Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change suggestions for MLX42: docs and code #178

Open
552020 opened this issue Feb 17, 2024 · 0 comments
Open

Change suggestions for MLX42: docs and code #178

552020 opened this issue Feb 17, 2024 · 0 comments

Comments

@552020
Copy link
Collaborator

552020 commented Feb 17, 2024

  1. We struggled a little bit understanding that the image is automatically updated by the library: was it just our incapacity to read the docs, or is it not explained good enough.

  2. @552020 is highly unstatisfied with the naming of the variable pixel in the helper function of mlx_put_pixel. Cause that variable designes the channel of a pixel (the 8-bit section of a 32-bit pixel) and not the whole pixel.

           > It sounds like not being a virgin anymore
    

Yes, I add a PR in MLX42 already accepted! I spot a typo it's instead of its! 😀

The doc for MLX is quite light (maybe intentionnaly) but it is true that this seems to be an essential information

Just for me to be clear about it, we are talking about the fact that in MLX42 when you modify an image that you already put to the window the library already update the image in the window without the need of reputting it on the window, and this is the reason why the minimap (as a black background) was behind the walls. It would be anyway another issue than the one discussed in this issue.

Originally posted by @552020 in #152 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant