Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Improve Docs components - add StyleProps, remove def… #1571

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Feat(web-react): Improve Docs components - add StyleProps, remove def… #1571

merged 1 commit into from
Aug 13, 2024

Conversation

crishpeen
Copy link
Member

…aultProps and other minor fixes

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners August 7, 2024 09:04
@github-actions github-actions bot added the feature New feature or request label Aug 7, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit d71d57d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66b338b078ab8c000855ecd0
😎 Deploy Preview https://deploy-preview-1571--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit d71d57d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66b338b06cc80c00078fd15e

@crishpeen crishpeen mentioned this pull request Aug 7, 2024
Merged
@coveralls
Copy link

Coverage Status

coverage: 78.364% (+4.6%) from 73.772%
when pulling d71d57d on feat/docs-components
into bc55dd9 on main.

@crishpeen crishpeen requested a review from adamkudrna August 7, 2024 16:59
@crishpeen crishpeen merged commit 7b3ab46 into main Aug 13, 2024
16 checks passed
@crishpeen crishpeen deleted the feat/docs-components branch August 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @pavelklibani @curdaj