Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting from UMAP 0.4dev #37

Open
jlmelville opened this issue Apr 26, 2019 · 1 comment
Open

Backporting from UMAP 0.4dev #37

jlmelville opened this issue Apr 26, 2019 · 1 comment

Comments

@jlmelville
Copy link
Collaborator

In #16, there was mention of the UMAP 0.4dev branch having diverged substantially from pynndescent for the sparse code.

The non-sparse code doesn't seem to have been changed as much, though. The main change is in the nearest neighbor descent code; apart from that there is some variance in numba decoration, but that's about it.

If there is interest in porting UMAP 0.4dev code from utils.py, nn_descent.py and rp_trees.py back into pynndescent separately from the sparse or threaded code, I am happy to create a PR, so at least there are some diffs which can be examined to work out which bits to use from each code base.

@tomwhite
Copy link
Collaborator

Thanks for opening this issue @jlmelville. My goal is really to remove duplication, and have umap use the nn-descent code from this project at some point.

I am happy to create a PR, so at least there are some diffs which can be examined to work out which bits to use from each code base.

That sounds like it would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants