Skip to content

Commit

Permalink
fofb_shaper_filt_pkg.vhd: reduce maximum filter order
Browse files Browse the repository at this point in the history 
Even with the optimizations from the latest commits, synthesis can't
close timing.

By now, the two options we found that solve this issue are:

  1. Reduce the number of supported channels from 12 to 8.
  2. Reduce the maximum filter order from 10 to 8.

We picked option 2:
Although current operation doesn't require more than 8 channels, we want
to keep those 4 extras as a backup for any malfuction. Also, we
currently don't have a real demand for {9,10}th order filters.

The testbench files changed accordingly.
  • Loading branch information
@guilhermerc
guilhermerc committed Apr 15, 2024
1 parent 730c98e commit 91b303d
Show file tree
Hide file tree
Showing 4 changed files with 215 additions and 215 deletions.
2 changes: 1 addition & 1 deletion hdl/modules/fofb_shaper_filt/fofb_shaper_filt_pkg.vhd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ USE work.wishbone_pkg.ALL;

PACKAGE fofb_shaper_filt_pkg IS
-- The maximum filter order supported
CONSTANT c_MAX_FILT_ORDER : NATURAL := 10;
CONSTANT c_MAX_FILT_ORDER : NATURAL := 8;

-- The signed fixed-point representation of filters' coefficients
CONSTANT c_COEFF_INT_WIDTH : NATURAL := 2;
Expand Down
24 changes: 12 additions & 12 deletions hdl/testbench/xwb_fofb_shaper_filt/fofb_shaper_filt_coeffs.dat
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
2.89644590e-03 5.79289180e-03 2.89644590e-03 -7.11236625e-17 6.19395866e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 5.76378106e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 1.71572875e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 3.75524806e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.11022302e-16 7.29453817e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
9.26728558e-03 1.85345712e-02 9.26728558e-03 -1.38777878e-16 9.70055654e-03 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.94289029e-16 9.20192105e-02 1.00000000e+00 2.00000000e+00 1.00000000e+00 -1.66533454e-16 2.85702154e-01 1.00000000e+00 2.00000000e+00 1.00000000e+00 -2.22044605e-16 6.73513678e-01
Loading

0 comments on commit 91b303d

Please sign in to comment.