Fix ServerAddr UInt8Array to Buffer for thrift (openzipkin#100)

lnshi · Apr 11, 2017 · 7f032e1 · 7f032e1
1 parent 518bf0d
commit 7f032e1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/zipkin-transport-scribe/test/integrationTest.js b/packages/zipkin-transport-scribe/test/integrationTest.js
@@ -46,6 +46,7 @@ describe('Scribe transport - integration test', () => {
           flags: 0
         });
         tracer.setId(id);
+        tracer.recordAnnotation(new Annotation.ServerAddr({serviceName: 'test'}));
         tracer.recordAnnotation(new Annotation.ClientSend());
         tracer.recordAnnotation(new Annotation.ClientRecv());
         setTimeout(() => {

diff --git a/packages/zipkin/src/internalRepresentations.js b/packages/zipkin/src/internalRepresentations.js
@@ -91,8 +91,7 @@ function Address({key, endpoint}) {
   this.endpoint = endpoint;
 }
 Address.prototype.toThrift = function toThrift() {
-  const value = new Uint8Array(1);
-  value[0] = 1;
+  const value = Buffer.from([1]);
   const res = new thriftTypes.BinaryAnnotation({
     key: this.key,
     value,