Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Saas App with client side rendering creates unecessary code #1119

Open
JonasCir opened this issue Dec 31, 2024 · 2 comments
Open

Comments

@JonasCir
Copy link

Description

When executing loco newand choosing What would you like to build? · Saas App with client side rendering, some code only relevant to SSR is created.

To Reproduce

  1. Run loco new
  2. Select ❯ What would you like to build? · Saas App with client side rendering
  3. Inspect created project

Expected Behavior

Specifically the following items are created which are not necessary:

  • impl Hooks for App section in app.rs contains the initializer for ViewEngine, not necessary for CSR
  • initializers/view_engine.rs is not needed for CSR, the file and corresponding mod declarations and imports can be removed
  • asset folder contains subfolder with unnecessary items. All of them can be removed.
  • fluent-templates and unic-langid dependency can be removed from Cargo.toml

Environment:
loco 0.13.3 and rustc 1.83.0 (90b35a623 2024-11-26) stable linux toolchain.

Additional Context

Discovered while trying out different CSR UI frameworks

@JonasCir
Copy link
Author

Also, I would like to volunteer to work on this :) Sounds like good first issue to me 😃

@kaplanelad
Copy link
Contributor

@JonasCir go for it.
let me know if your need help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants