Skip to content

Commit

Permalink
feat(ingest): Use NCBI API key, and don't retry, to not exceed reques…
Browse files Browse the repository at this point in the history
…t limits (#1845)

-Don't retry when NCBI ingest fails, as this causes rate limits to trip
-Use NCBI API Key. In cleartext for now (while we're private that's no problem). It's easy to generate these keys and easy to reset so there's no risk to using it like this right now. For proper encryption see Set NCBI API key through secret #1844
  • Loading branch information
corneliusroemer authored May 10, 2024
1 parent 3a1ea87 commit 1dbfcba
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ingest/Snakefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,15 @@ rule all:


rule fetch_ncbi_dataset_package:
# TODO: #1844 Set API key through secret
output:
dataset_package="results/ncbi_dataset.zip",
retries: 5
shell:
"""
datasets download virus genome taxon {TAXON_ID} \
--no-progressbar \
--filename {output.dataset_package}
--filename {output.dataset_package} \
--api-key 15c4ff96de265753f878bb08d88ca64df909 \
"""


Expand Down

0 comments on commit 1dbfcba

Please sign in to comment.