From 1dbfcba6b903eeb6fe01e24ffa20ea306d69f2e4 Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Fri, 10 May 2024 08:39:10 +0200 Subject: [PATCH] feat(ingest): Use NCBI API key, and don't retry, to not exceed request limits (#1845) -Don't retry when NCBI ingest fails, as this causes rate limits to trip -Use NCBI API Key. In cleartext for now (while we're private that's no problem). It's easy to generate these keys and easy to reset so there's no risk to using it like this right now. For proper encryption see Set NCBI API key through secret #1844 --- ingest/Snakefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ingest/Snakefile b/ingest/Snakefile index 8b47ecc2a..3c0a6a610 100644 --- a/ingest/Snakefile +++ b/ingest/Snakefile @@ -38,14 +38,15 @@ rule all: rule fetch_ncbi_dataset_package: + # TODO: #1844 Set API key through secret output: dataset_package="results/ncbi_dataset.zip", - retries: 5 shell: """ datasets download virus genome taxon {TAXON_ID} \ --no-progressbar \ - --filename {output.dataset_package} + --filename {output.dataset_package} \ + --api-key 15c4ff96de265753f878bb08d88ca64df909 \ """