Make config values clearer

ena-submission/config/defaults.yaml

@@ -11,8 +11,7 @@ github_username: fake_username
 github_pat: fake_pat
 github_url: https://api.github.com/repos/pathoplexus/ena-submission/contents/test/approved_ena_submission_list.json?ref=main # TODO(https://github.com/loculus-project/loculus/issues/2425): update in production
 ena_reports_service_url: https://wwwdev.ebi.ac.uk/ena/submit/report # TODO(https://github.com/loculus-project/loculus/issues/2425): update in production
-ena_checklist: ERC000033
-use_ena_checklist: false
+#ena_checklist: ERC000033 - do not use until all fields are mapped to ENA accepted options
 metadata_mapping:
   'subject exposure':
     loculus_fields: [exposureEvent]

ena-submission/scripts/create_sample.py

@@ -147,7 +147,8 @@ def construct_sample_set_object(
     else:
         alias = XmlAttribute(f"{entry["accession"]}:{organism}:{config.unique_project_suffix}")
     list_sample_attributes = get_sample_attributes(config, sample_metadata, entry)
-    if config.use_ena_checklist:
+    if config.ena_checklist:
+        # default is https://www.ebi.ac.uk/ena/browser/view/ERC000011
         sample_checklist = SampleAttribute(
             tag="ENA-CHECKLIST",
             value=config.ena_checklist,

ena-submission/scripts/test_ena_submission.py

@@ -48,7 +48,7 @@ def mock_config():
     config.metadata_mapping_mandatory_field_defaults = defaults[
         "metadata_mapping_mandatory_field_defaults"
     ]
-    config.ena_checklist = defaults["ena_checklist"]
+    config.ena_checklist = "ERC000033"
     return config