feat(website): show a meaningful error if uploaded file is too large #1634
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -423,6 +423,11 @@ function handleError(onError: (message: string) => void, action: Action) { | |||
| case 400: | |||
| onError('Failed to submit sequence entries: ' + error.response.data.detail); | |||
| return; | |||
| case 413: | |||
| onError( | |||
| 'The uploaded file was too large. Please compress the file or split it into smaller submissions.', | |||
There was a problem hiding this comment.
Do you know where we configure how large is too large? It would be nice to give as specific a response as possible - e.g. "the maximum allowed size is X MB"
There was a problem hiding this comment.
I've been also wondering.. I found a config in the backend which however seems to allow 5 GB. Maybe (for our non-local deployments) there is some web server in Kubernetes that sets a more strict limit by default? Do you understand what we have between the backend and the public internet?
chaoran-chen
force-pushed
the
1226-file-too-big-error
branch
from
e5cbe92 to
5d200ff
Compare
|
As in #1635 (comment) it seems like this likely relates to CloudFlare. (You could see if it happens locally) |
chaoran-chen
force-pushed
the
1226-file-too-big-error
branch
from
cdc6de1 to
f8ba992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1226
preview URL: https://1226-file-too-big-error.loculus.org
Summary
Screenshot
PR Checklist
This is blocked by #1635 because the web application cannot see the response status due to CORS errors.