feat(deployment): Add compression middleware for the website #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
chaoran-chen
approved these changes
May 10, 2024
|
Can we configure the compression? Or does it automatically pick zstd over gzip? Currently only gzip and br supported, I'll open an issue for zstd :p https://doc.traefik.io/traefik/middlewares/http/compress/ It also says only uncompressed requests are compressed, so we can sprinkle this pretty much everywhere. |
|
Looks like for Traefik V2 it's just gzip |
corneliusroemer
pushed a commit
that referenced
this pull request
May 10, 2024
* add compression middleware * update * fix (cherry picked from commit b64b535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compression middleware for the website, handled by traefik. This reduces e.g. the submission page from transferring 1.1 MB of resources to transferring 323 kB.
We can reuse this middleware in other parts of the deployment later in cases that do not already handle compression.
https://add-compression-middlewar.loculus.org/