Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-quadratic slew rate line search #12

Open
bamos opened this issue Oct 24, 2018 · 2 comments
Open

Non-quadratic slew rate line search #12

bamos opened this issue Oct 24, 2018 · 2 comments

Comments

@bamos
Copy link
Member

bamos commented Oct 24, 2018

If I understand correctly, 206bd93 does the LQR step with the slew rate penalty in the quadratic cost approximation, but does the line search on the unmodified cost function without the slew rate penalty.

This is non-trivial to fix because we currently have a time-invariant non-quadratic cost function and no easy way to access the nominal control trajectory within it. If we did, the clean solution would be to write a new cost function with the slew rate penalty. Instead, perhaps the easiest way of fixing this would be to add the slew rate to the get_cost function.

@ivandariojr
Copy link
Contributor

That is correct I forgot we were using the true cost for the line search.

@bamos
Copy link
Member Author

bamos commented Nov 1, 2018

I just added an error message for this case so nobody accidentally starts getting silent errors from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants