refactor-tests #15
Merged
refactor-tests #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tender-barbarian
force-pushed
the
refactor-tests
branch
from
d6aa921 to
6a3bd38
Compare
tender-barbarian
force-pushed
the
refactor-tests
branch
from
6a3bd38 to
f0d21ed
Compare
elvecz
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that unit test for anonymizer was wrong. It was expecting a deterministic output by attempting to disable randomization, which kind of defeats the purpose... So I rewrote it to validate anonymised values based on their type and whether they are different from input.
I also removed integration test as it was just repeating what was already tested in unit tests. It needs to be rewritten to something more useful, but that will be a subject of another PR.