Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to centralized travis configuration #126

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Mar 27, 2020

same work as logstash-plugins/logstash-input-elasticsearch#120

test failure is valid but unrelated to this refactoring.

use most of the work done in the es input travis refactor here:
logstash-plugins/logstash-input-elasticsearch#120
@jsvd jsvd force-pushed the centralize_travis_testing branch from 497fce0 to 0ad416a Compare March 27, 2020 15:31
@jsvd jsvd marked this pull request as ready for review March 27, 2020 15:32
@elasticsearch-bot elasticsearch-bot self-assigned this Mar 27, 2020
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can we also create an issue for the unrelated test failure?

@jsvd
Copy link
Member Author

jsvd commented Mar 27, 2020

Issue created here #127 to track the integration test failure.

@jsvd jsvd merged commit a25e92d into logstash-plugins:master Mar 27, 2020
@jsvd jsvd deleted the centralize_travis_testing branch March 27, 2020 23:43
jsvd added a commit to logstash-plugins/logstash-output-elasticsearch that referenced this pull request Mar 30, 2020
same work as done in the logstash-plugins/logstash-filter-elasticsearch#126 and logstash-plugins/logstash-input-elasticsearch#120.

The only difference is that integration tests need to know the exact elasticsearch version being tested (but the input can be "7.x"). This PR modifies the .ci/logstash-run to fetch the version from elasticsearch itself.

Co-authored-by: Karol Bucek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants