Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize travis testing #930

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Mar 27, 2020

same work as done in the logstash-plugins/logstash-filter-elasticsearch#126 and logstash-plugins/logstash-input-elasticsearch#120.

The only difference is that integration tests need to know the exact elasticsearch version being tested (but the input can be "7.x"). This PR modifies the .ci/logstash-run to fetch the version from elasticsearch itself.

@jsvd jsvd force-pushed the centralize_travis_testing branch 2 times, most recently from 910125a to 68c97d7 Compare March 27, 2020 16:10
@jsvd jsvd force-pushed the centralize_travis_testing branch from 1ed2070 to 5183135 Compare March 28, 2020 12:14
@jsvd jsvd marked this pull request as ready for review March 28, 2020 12:15
@elasticsearch-bot elasticsearch-bot self-assigned this Mar 30, 2020
Copy link
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: Karol Bucek <[email protected]>
@andsel andsel assigned jsvd and unassigned elasticsearch-bot Mar 30, 2020
@jsvd jsvd merged commit df32e53 into logstash-plugins:master Mar 30, 2020
@jsvd jsvd deleted the centralize_travis_testing branch March 30, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants