From 038a0925f70032fe2657052bf736a5894ece0a68 Mon Sep 17 00:00:00 2001
From: arenard <arenard@gmail.com>
Date: Sun, 24 Feb 2019 19:18:57 +0100
Subject: [PATCH] Changed expected datatype of `request_timeout_ms` option to
 number

---
 CHANGELOG.md                  | 4 ++++
 docs/index.asciidoc           | 4 ++--
 lib/logstash/outputs/kafka.rb | 2 +-
 logstash-output-kafka.gemspec | 2 +-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8526f0f..9d4047f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 9.0.0
+  - Changed expected datatype of `request_timeout_ms` option to number
+    [#222](https://github.com/logstash-plugins/logstash-output-kafka/pull/222)
+
 ## 8.0.1
   - Fixed issue with unnecessary sleep after retries exhausted [#216](https://github.com/logstash-plugins/logstash-output-kafka/pull/216)
 
diff --git a/docs/index.asciidoc b/docs/index.asciidoc
index a32bf0a..ea59777 100644
--- a/docs/index.asciidoc
+++ b/docs/index.asciidoc
@@ -75,7 +75,7 @@ This plugin supports the following configuration options plus the <<plugins-{typ
 | <<plugins-{type}s-{plugin}-metadata_max_age_ms>> |<<number,number>>|No
 | <<plugins-{type}s-{plugin}-receive_buffer_bytes>> |<<number,number>>|No
 | <<plugins-{type}s-{plugin}-reconnect_backoff_ms>> |<<number,number>>|No
-| <<plugins-{type}s-{plugin}-request_timeout_ms>> |<<string,string>>|No
+| <<plugins-{type}s-{plugin}-request_timeout_ms>> |<<number,number>>|No
 | <<plugins-{type}s-{plugin}-retries>> |<<number,number>>|No
 | <<plugins-{type}s-{plugin}-retry_backoff_ms>> |<<number,number>>|No
 | <<plugins-{type}s-{plugin}-sasl_kerberos_service_name>> |<<string,string>>|No
@@ -266,7 +266,7 @@ The amount of time to wait before attempting to reconnect to a given host when a
 [id="plugins-{type}s-{plugin}-request_timeout_ms"]
 ===== `request_timeout_ms` 
 
-  * Value type is <<string,string>>
+  * Value type is <<number,number>>
   * There is no default value for this setting.
 
 The configuration controls the maximum amount of time the client will wait
diff --git a/lib/logstash/outputs/kafka.rb b/lib/logstash/outputs/kafka.rb
index 6f29b2d..a9454e4 100644
--- a/lib/logstash/outputs/kafka.rb
+++ b/lib/logstash/outputs/kafka.rb
@@ -108,7 +108,7 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
   # for the response of a request. If the response is not received before the timeout
   # elapses the client will resend the request if necessary or fail the request if
   # retries are exhausted.
-  config :request_timeout_ms, :validate => :string
+  config :request_timeout_ms, :validate => :number
   # The default retry behavior is to retry until successful. To prevent data loss,
   # the use of this setting is discouraged.
   #
diff --git a/logstash-output-kafka.gemspec b/logstash-output-kafka.gemspec
index 19d2c20..2a40cbc 100644
--- a/logstash-output-kafka.gemspec
+++ b/logstash-output-kafka.gemspec
@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-output-kafka'
-  s.version         = '8.0.1'
+  s.version         = '9.0.0'
   s.licenses        = ['Apache-2.0']
   s.summary         = "Writes events to a Kafka topic"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"