Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing LW2 attempt to fix corpses dropped by MC-ed enemies #1639

Open
copyrite opened this issue Dec 21, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@copyrite
Copy link
Collaborator

copyrite commented Dec 21, 2023

Copied from Tedster59#29 by @GafrieGithub. Let's use this as the main issue for mind controlled units' loot and corpse topics. Related: #706, #987, #1078.

Here is the LW2 code which make enemies who are mind controlled at the end of full salvage missions to drop their corpses:

lwotc/LongWarOfTheChosen/Src/LW_Overhaul/Classes/X2EventListener_Tactical.uc

Line 687 in 4957602
else if (EffectState.GetX2Effect().EffectName == class'X2Effect_MindControl'.default.EffectName && AwardWrecks)

However, it works poorly with mods like "[WOTC] Dude, Where's My Loot?" or formerly "[WOTC] Loot Mind Control" in that LW2 fixes only the corpses. If you are not using other mod, then you are missing on certain loot, and if you are using other mod then you get your loot, but also double the amount of corpses. So no matter what you do currently the overall amount of stuff you get is incorrect.
The easiest solution would be just to comment this section out and to warn players to just use a mod specifically focused on solving this issue.

@copyrite copyrite added the bug Something isn't working label Dec 21, 2023
@allenhu0912
Copy link

Dude, Where's My Loot? mod author claims that his implementation should not cause duplicate corpses in LWOTC, haven't personally tried it yet.

@Tedster59
Copy link
Collaborator

Given the author of the bug report on my fork is the author of Dude, Where's My Loot? I think it doesn't account for LWoTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants