Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing of workspace.metadata.i18n #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

litcc
Copy link

@litcc litcc commented Sep 10, 2024

minor changes

The current cli only supports reading [package.metadata.i18n], but when there is no package entry in the project root, but there is [workspace.metadata.i18n] data, the available-locales and the available-locales are not read based on the attributes in the workspace. default-locale, resulting in a TODO that only detects en when executing cargo i18n in other languages.

For example, when this is the case:

https://github.com/longbridgeapp/rust-i18n/tree/84ac7dbb598f39901cd5fbc511664ae3cc36b4c1/examples/share-in-workspace

Although it is possible to pass the specified parameters by adding [i18n] directly to Cargo.toml, it is annoying to be prompted with a warning when executing cargo build or other commands!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant