From 3a320d860af4cdcb9741f60448b6966969ba3779 Mon Sep 17 00:00:00 2001 From: Jack Yu Date: Wed, 25 Sep 2024 17:10:02 +0800 Subject: [PATCH] feat: support to build in Darwin Signed-off-by: Jack Yu --- io/file.go | 13 +++++++------ ns/joiner.go | 27 +-------------------------- ns/joiner_darwin.go | 10 ++++++++++ ns/joiner_linux.go | 38 ++++++++++++++++++++++++++++++++++++++ sys/sys.go | 6 +++--- types/namespace.go | 11 ----------- types/namespace_darwin.go | 5 +++++ types/namespace_linux.go | 14 ++++++++++++++ 8 files changed, 78 insertions(+), 46 deletions(-) create mode 100644 ns/joiner_darwin.go create mode 100644 ns/joiner_linux.go create mode 100644 types/namespace_darwin.go create mode 100644 types/namespace_linux.go diff --git a/io/file.go b/io/file.go index d4ad1c00..aea7fd4b 100644 --- a/io/file.go +++ b/io/file.go @@ -12,6 +12,7 @@ import ( "github.com/pkg/errors" "github.com/shirou/gopsutil/v3/disk" "github.com/sirupsen/logrus" + "golang.org/x/sys/unix" "github.com/longhorn/go-common-libs/types" ) @@ -227,8 +228,8 @@ func GetDiskStat(path string) (diskStat types.DiskStat, err error) { err = errors.Wrapf(err, "failed to get fs stat for %v", path) }() - var statfs syscall.Statfs_t - if err := syscall.Statfs(path, &statfs); err != nil { + var statfs unix.Statfs_t + if err := unix.Statfs(path, &statfs); err != nil { return diskStat, err } @@ -239,7 +240,7 @@ func GetDiskStat(path string) (diskStat types.DiskStat, err error) { // Convert the FSID components to a single uint64 FSID value var fsidValue uint64 - for _, component := range statfs.Fsid.X__val { + for _, component := range statfs.Fsid.Val { // Combine components using bit manipulation fsidValue = (fsidValue << 32) | uint64(uint32(component)) } @@ -254,9 +255,9 @@ func GetDiskStat(path string) (diskStat types.DiskStat, err error) { Driver: types.DiskDriverNone, FreeBlocks: int64(statfs.Bfree), TotalBlocks: int64(statfs.Blocks), - BlockSize: statfs.Bsize, - StorageMaximum: int64(statfs.Blocks) * statfs.Bsize, - StorageAvailable: int64(statfs.Bfree) * statfs.Bsize, + BlockSize: int64(statfs.Bsize), + StorageMaximum: int64(statfs.Blocks) * int64(statfs.Bsize), + StorageAvailable: int64(statfs.Bfree) * int64(statfs.Bsize), }, nil } diff --git a/ns/joiner.go b/ns/joiner.go index b62e9c9b..09c7ace1 100644 --- a/ns/joiner.go +++ b/ns/joiner.go @@ -46,31 +46,6 @@ func (joiners *Joiners) JoinReverse() (err error) { return joiners.Join() } -// Join joins all the namespaces in the Joiners. -func (joiners *Joiners) Join() (err error) { - for _, joiner := range *joiners { - if joiner.isJoined { - logrus.Tracef("Already joined namespace: %s", joiner.namespace) - continue - } - - if joiner.namespace == types.NamespaceMnt { - err := unix.Unshare(unix.CLONE_NEWNS) - if err != nil { - return errors.Wrapf(err, "failed to unshare namespace: %+s", joiner.namespace) - } - } - - if err := unix.Setns(joiner.fd, 0); err != nil { - return errors.Wrapf(err, "failed to set namespace: %+s", joiner.namespace) - } - - joiner.isJoined = true - logrus.Tracef("Joined namespace: %v", joiner.namespace) - } - return nil -} - // Reset resets all the Joiners. func (joiners *Joiners) Reset() (err error) { for _, joiner := range *joiners { @@ -214,7 +189,7 @@ func (jd *JoinerDescriptor) openAndRecordNamespaceFiles(namespace types.Namespac // The original namespace file is the namespace file of the process thread that is // executing the joiner (e.g. /proc/1/task/2/ns/mnt) func (jd *JoinerDescriptor) openAndRecordOriginalNamespaceFile(ns string, namespace types.Namespace) error { - pthreadFile := filepath.Join("/proc", fmt.Sprint(os.Getpid()), "task", fmt.Sprint(unix.Gettid()), "ns", ns) + pthreadFile := filepath.Join("/proc", fmt.Sprint(os.Getpid()), "task", fmt.Sprint(Gettid()), "ns", ns) originFd, err := jd.origin.OpenFile(pthreadFile) if err != nil { return errors.Wrapf(err, "failed to open process thread file %v", pthreadFile) diff --git a/ns/joiner_darwin.go b/ns/joiner_darwin.go new file mode 100644 index 00000000..4a2a2e05 --- /dev/null +++ b/ns/joiner_darwin.go @@ -0,0 +1,10 @@ +package ns + +// Join joins all the namespaces in the Joiners. +func (joiners *Joiners) Join() (err error) { + return nil +} + +func Gettid() int { + return 0 +} diff --git a/ns/joiner_linux.go b/ns/joiner_linux.go new file mode 100644 index 00000000..a05ce801 --- /dev/null +++ b/ns/joiner_linux.go @@ -0,0 +1,38 @@ +package ns + +import ( + "github.com/pkg/errors" + "github.com/sirupsen/logrus" + "golang.org/x/sys/unix" + + "github.com/longhorn/go-common-libs/types" +) + +// Join joins all the namespaces in the Joiners. +func (joiners *Joiners) Join() (err error) { + for _, joiner := range *joiners { + if joiner.isJoined { + logrus.Tracef("Already joined namespace: %s", joiner.namespace) + continue + } + + if joiner.namespace == types.NamespaceMnt { + err := unix.Unshare(unix.CLONE_NEWNS) + if err != nil { + return errors.Wrapf(err, "failed to unshare namespace: %+s", joiner.namespace) + } + } + + if err := unix.Setns(joiner.fd, 0); err != nil { + return errors.Wrapf(err, "failed to set namespace: %+s", joiner.namespace) + } + + joiner.isJoined = true + logrus.Tracef("Joined namespace: %v", joiner.namespace) + } + return nil +} + +func Gettid() int { + return unix.Gettid() +} diff --git a/sys/sys.go b/sys/sys.go index e4e23a30..076d3dcc 100644 --- a/sys/sys.go +++ b/sys/sys.go @@ -6,18 +6,18 @@ import ( "path/filepath" "strconv" "strings" - "syscall" "github.com/pkg/errors" "github.com/sirupsen/logrus" + "golang.org/x/sys/unix" "github.com/longhorn/go-common-libs/types" ) // GetKernelRelease returns the kernel release string. func GetKernelRelease() (string, error) { - utsname := &syscall.Utsname{} - if err := syscall.Uname(utsname); err != nil { + utsname := &unix.Utsname{} + if err := unix.Uname(utsname); err != nil { logrus.WithError(err).Warn("Failed to get kernel release") return "", err } diff --git a/types/namespace.go b/types/namespace.go index 7358a407..b0c56623 100644 --- a/types/namespace.go +++ b/types/namespace.go @@ -2,8 +2,6 @@ package types import ( "time" - - "golang.org/x/sys/unix" ) const ( @@ -28,15 +26,6 @@ const ( NamespaceNet = Namespace("net") ) -func (ns Namespace) Flag() uintptr { - switch ns { - case NamespaceNet: - return unix.CLONE_NEWNET - default: - return 0 - } -} - func (ns Namespace) String() string { return string(ns) } diff --git a/types/namespace_darwin.go b/types/namespace_darwin.go new file mode 100644 index 00000000..baf5465f --- /dev/null +++ b/types/namespace_darwin.go @@ -0,0 +1,5 @@ +package types + +func (ns Namespace) Flag() uintptr { + return 0 +} diff --git a/types/namespace_linux.go b/types/namespace_linux.go new file mode 100644 index 00000000..a0c18fd2 --- /dev/null +++ b/types/namespace_linux.go @@ -0,0 +1,14 @@ +package types + +import ( + "golang.org/x/sys/unix" +) + +func (ns Namespace) Flag() uintptr { + switch ns { + case NamespaceNet: + return unix.CLONE_NEWNET + default: + return 0 + } +}