Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning/logging when max recording is reached #383

Open
becky-gilbert opened this issue May 20, 2024 · 0 comments
Open

Add warning/logging when max recording is reached #383

becky-gilbert opened this issue May 20, 2024 · 0 comments

Comments

@becky-gilbert
Copy link
Contributor

Summary

We recently encountered a problem with the attempted download of a very large recording file. The EFP experiment runner has a maximum recording duration that should prevent experiments from producing very large recordings in the first place. Currently, if the maximum duration is reached then there is a warning in the browser's console, but can easily go unnoticed since it doesn't actually alert the participant or researcher.

Implementation notes

We should consider options for logging that the upper recording limit has been reached. Perhaps the most straightforward option is to add this as a flag to the JSON response data (e.g. exceededUpperRecordingLimit: true). Here's the relevant bit of EFP code for handling recordings that have exceeded the time limit.

Other options:

  • Log an error in Sentry (I'm not sure if it's possible to throw a custom error that is picked up by Sentry but doesn't disrupt the experiment)
  • Add a message to the page, something like "Maximum recording time reached - stopping the recording." But this might not be ideal in some cases, and it would need to be translated for non-English studies.

Whatever we decide to do in EFP, we should make note of for lookit-jspsych as we will want to do the same thing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant