Unmuted recorded consent playback (#65)

* Play should not be muted. * Changeset * Test
lookit · Oct 16, 2024 · 496b62d · 496b62d
1 parent ed5ea88
commit 496b62d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/silver-pigs-develop.md b/.changeset/silver-pigs-develop.md
@@ -0,0 +1,5 @@
+---
+"@lookit/record": patch
+---
+
+Unmute playback of recorded consent video.
diff --git a/packages/record/src/consentVideo.spec.ts b/packages/record/src/consentVideo.spec.ts
@@ -2,6 +2,7 @@ import { LookitWindow } from "@lookit/data/dist/types";
 import Handlebars from "handlebars";
 import { initJsPsych, PluginInfo, TrialType } from "jspsych";
 import consentVideoTrial from "../templates/consent-video-trial.hbs";
+import playbackFeed from "../templates/playback-feed.hbs";
 import recordFeed from "../templates/record-feed.hbs";
 import { VideoConsentPlugin } from "./consentVideo";
 import {
@@ -272,3 +273,7 @@ test("nextButton", () => {
 
   expect(jsPsych.finishTrial).toHaveBeenCalledTimes(1);
 });
+
+test("Video playback should not be muted", () => {
+  expect(playbackFeed).not.toContain("muted");
+});
diff --git a/packages/record/templates/playback-feed.hbs b/packages/record/templates/playback-feed.hbs
@@ -1,7 +1,6 @@
 <video
   autoplay
   playsinline
-  muted
   src="{{{src}}}"
   id="{{webcam_element_id}}"
   width="{{width}}"