Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(?) - allow no additional segments in consent #84

Closed
mekline opened this issue Oct 24, 2024 · 1 comment · Fixed by #89
Closed

Bug(?) - allow no additional segments in consent #84

mekline opened this issue Oct 24, 2024 · 1 comment · Fixed by #89
Assignees

Comments

@mekline
Copy link

mekline commented Oct 24, 2024

While trying to update the video-consent plugin I tried removing the additional_segments parameter and got the following error:

Uncaught (in promise) Error: You must specify a value for the "additional_segments" parameter in the "consent-video" plugin.

It would be more natural for the plugin to allow this to be null, and not require the user to input additional_segments: [{}] (which fixes this bug)

@mekline
Copy link
Author

mekline commented Oct 24, 2024

(Only tried this on video-consent, consent_005, English, same issue may be present in other versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants