Hide circular dependency warnings #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1cf62b The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
okaycj
force-pushed
the
hide-circular-deps-warnings
branch
from
c409943 to
66824e7
Compare
okaycj
force-pushed
the
hide-circular-deps-warnings
branch
from
f3d068d to
c1cf62b
Compare
becky-gilbert
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At this point, we accept that AWS (and its dependencies) will have some circular dependency warnings with Rollup. To hide them without also hiding warnings we'd like to address, I've created a list of strings to identify the warnings we've already run across. Additionally, I've changed "warnings" to "errors." This will help catch issues with Rollup before they accidentally end up in production.