Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmuted recorded consent playback #65

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Unmuted recorded consent playback #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b315468
Play should not be muted.
okaycj Oct 15, 2024
8b67308
Changeset
okaycj Oct 15, 2024
1622826
Test
okaycj Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-pigs-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lookit/record": patch
---

Unmute playback of recorded consent video.
5 changes: 5 additions & 0 deletions packages/record/src/consentVideo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { LookitWindow } from "@lookit/data/dist/types";
import Handlebars from "handlebars";
import { initJsPsych, PluginInfo, TrialType } from "jspsych";
import consentVideoTrial from "../templates/consent-video-trial.hbs";
import playbackFeed from "../templates/playback-feed.hbs";
import recordFeed from "../templates/record-feed.hbs";
import { VideoConsentPlugin } from "./consentVideo";
import {
Expand Down Expand Up @@ -272,3 +273,7 @@ test("nextButton", () => {

expect(jsPsych.finishTrial).toHaveBeenCalledTimes(1);
});

test("Video playback should not be muted", () => {
expect(playbackFeed).not.toContain("muted");
});
1 change: 0 additions & 1 deletion packages/record/templates/playback-feed.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<video
autoplay
playsinline
muted
src="{{{src}}}"
id="{{webcam_element_id}}"
width="{{width}}"
Expand Down