Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates and translations #68

Merged
merged 25 commits into from
Oct 17, 2024
Merged

Templates and translations #68

merged 25 commits into from
Oct 17, 2024

Conversation

okaycj
Copy link
Collaborator

@okaycj okaycj commented Oct 16, 2024

Summary

This PR moves two templates and translations to a new "Templates" package. This new package is the location of templates and their translations moving forward.

For Another PR

  • Add the ability to select which version of the template is needed.

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 7049617

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lookit/templates Patch
@lookit/record Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okaycj okaycj force-pushed the templates-and-translations branch from 4b17a30 to c04e8ec Compare October 16, 2024 18:37
Copy link
Contributor

@becky-gilbert becky-gilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! I love the way this turned out - very nice and user friendly.

Approved pending passing checks 😄

I'll start a PR to move the video-consent template/translations into templates.

packages/record/src/consentVideo.spec.ts Show resolved Hide resolved
packages/style/package.json Show resolved Hide resolved
packages/record/hbs/video-config.hbs Outdated Show resolved Hide resolved
@becky-gilbert becky-gilbert linked an issue Oct 16, 2024 that may be closed by this pull request
@okaycj okaycj merged commit bb6754c into main Oct 17, 2024
2 checks passed
@okaycj okaycj deleted the templates-and-translations branch October 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support translations
2 participants