Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for loongarch64 #1

Open
wants to merge 1 commit into
base: la64/main
Choose a base branch
from
Open

add support for loongarch64 #1

wants to merge 1 commit into from

Conversation

yetist
Copy link

@yetist yetist commented May 9, 2022

No description provided.

@yetist yetist requested a review from a team May 9, 2022 10:13
@xen0n
Copy link
Member

xen0n commented May 9, 2022

fwupd的efi模块,龙芯固件团队是要准备接入LVFS服务了吗?

@yetist
Copy link
Author

yetist commented May 10, 2022

fwupd的efi模块,龙芯固件团队是要准备接入LVFS服务了吗?

有这个想法,准备先把基础设施做了。

Copy link
Member

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看上去不赖 👍

LVFS rocks 🚀 !

@@ -36,7 +36,7 @@ def _run_objcopy(args):

# aarch64 and arm32 don't have an EFI capable objcopy
# Use 'binary' instead, and add required symbols manually
if args.arch in ["aarch64", "arm"]:
if args.arch in ["aarch64", "arm", "loongarch64"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上边那个注释更新一下,these arches don't have

@@ -150,7 +150,7 @@ efi_ldflags = ['-T',
'-L', efi_crtdir,
'-L', efi_libdir,
join_paths(efi_crtdir, arch_crt)]
if host_cpu == 'aarch64' or host_cpu == 'arm'
if host_cpu == 'aarch64' or host_cpu == 'arm' or host_cpu == 'loongarch64'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if host_cpu == 'aarch64' or host_cpu == 'arm' or host_cpu == 'loongarch64'
if host_cpu in ['aarch64', 'arm', 'loongarch64']

@@ -0,0 +1,103 @@
OUTPUT_FORMAT("elf64-loongarch", "elf64-loongarch", "elf64-loongarch")
OUTPUT_ARCH(loongarch)
ENTRY(_start)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这文件哪抄的来着,gnu-efi?要等那边合并么?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是,基于同目录下的aarch64文件,改了开头2行

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants