Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an indeterminate progress bar #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtwaleson
Copy link

I'm using concrete.css for a mini project (thanks!) but needed an indeterminate progress bar.

This code adds it.

I copied some parts of the implementation from pico.css and stripped it down to a bare minimum. It supports not showing the animation for browsers that prefer reduced motion.

Tested on Chrome & Firefox on Linux.

Inspiration is taken from pico.css
@louismerlin
Copy link
Owner

Hello Jouke! Thank you very much for the PR, I super appreciate it.

I don’t know that I see concrete as having an animated element. I won’t be super online these next few days but I’ll iterate on your PR as soon as I’m able 😄

Or feel free to do it if you have an idea!

@jtwaleson
Copy link
Author

jtwaleson commented Nov 28, 2024

Hello Jouke! Thank you very much for the PR, I super appreciate it.

I don’t know that I see concrete as having an animated element. I won’t be super online these next few days but I’ll iterate on your PR as soon as I’m able 😄

Or feel free to do it if you have an idea!

As having an animated "indeterminate" state is natively supported by HTML I'd argue that it fits the spirit of concrete.css. I'm using my fork right now and in my application it "feels" very natural. Much better than the spinner I was using before. That'd be my reasoning but of course it's your call!

Please let me know if there are improvements you'd like to see in the PR and I'll give it my best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants