Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Node.js 22.x? #4281

Closed
trivikr opened this issue Nov 23, 2024 · 1 comment
Closed

Add CI for Node.js 22.x? #4281

trivikr opened this issue Nov 23, 2024 · 1 comment

Comments

@trivikr
Copy link

trivikr commented Nov 23, 2024

Feature request

What are you trying to achieve?

I was looking into the CI setup for sharp as part of upgrading Node.js 20.x version in bluesky-social/social-app#6357, and noticed that CI is not run on Node.js 22.x which went LTS on 2024-10-29

When you searched for similar feature requests, what did you find that might be related?

N/A. There is no issue discussing running CI in Node.js 22.x

What would you expect the API to look like?

No change in API. It's a request to test sharp in latest LTS of Node.js, i.e. 22.

What alternatives have you considered?

Waiting for Node.js 18.x support to be dropped, when Node.js 22.x support will likely be added, like it was done in ba20b8a

Please provide sample image(s) that help explain this feature

N/A

@lovell
Copy link
Owner

lovell commented Nov 23, 2024

Please see commit 6480a94 on the "hat" work-in-progress branch for this addition. Node.js 18 support will only be dropped after it reaches end-of-life, which is currently April 2025.

I would fully expect the existing latest version of sharp to work with Node.js 22. From what I can tell, the linked issue(s) relate to a previous version of Alpine Linux that provided a version of musl with an unusual/unexpected semver suffix.

@lovell lovell closed this as completed Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants