Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/notable): possible issues #1157

Open
lowlighter opened this issue Jul 25, 2022 Discussed in #1148 · 0 comments
Open

fix(plugins/notable): possible issues #1157

lowlighter opened this issue Jul 25, 2022 Discussed in #1148 · 0 comments

Comments

@lowlighter
Copy link
Owner

Discussed in #1148

Originally posted by jayvdb July 22, 2022
For the notable plugin, I set debug: true and plugin_notable_types: commit, issue, pull_request, and obviously have indepth enabled, and now I am seeing quite a few of the following in the log

metrics/compute/jayvdb/plugins > notable > indepth > successfully processed ansible/ansible-lint
TypeError: contributions.filter is not a function
      at Object.default [as notable] (file:///metrics/source/plugins/notable/index.mjs:83:41)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async file:///metrics/source/plugins/core/index.mjs:67:30
      at async Promise.all (index 0)
      at async metrics (file:///metrics/source/app/metrics/index.mjs:64:22)
      at async retry.retries.retries (file:///metrics/source/app/action/index.mjs:398:34)
      at async retry (file:///metrics/source/app/action/index.mjs:57:22)
      at async file:///metrics/source/app/action/index.mjs:397:20
  metrics/compute/jayvdb/plugins > notable > indepth > failed to compute for pdm-project/pdm
  metrics/compute/jayvdb/plugins > notable > indepth > successfully processed TheLartians/ModernCppStarter

Run: https://github.com/jayvdb/jayvdb/runs/7468279468?check_suite_focus=true

I don't have any commits in that repo, but I did create an issue: https://github.com/pdm-project/pdm/issues/created_by/jayvdb

pdm now appears in my svg jayvdb/jayvdb@01ec971 without any of the numerical scores inside its circle.

So I am guessing that plugin_notable_types of issue & pull_request are incompatible with indepth at the moment, unless there was a commit also in the repo.

But the problem is a bit more nuanced than that, as I only have a rejected issue in TheLartians/ModernCppStarter#131, and only an unmerged closed PR in ansible/ansible-lint#2196 - both repos that were "successfully processed".

@github-actions github-actions bot added the Stale label Dec 9, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2022
@lowlighter lowlighter removed the Stale label Dec 18, 2022
@lowlighter lowlighter reopened this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant