diff --git a/CHANGELOG.rst b/CHANGELOG.rst index f5d5aff0..a9c7adc6 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,19 @@ lowlydba.sqlserver Release Notes .. contents:: Topics +v2.3.2 +====== + +Release Summary +--------------- + +Small fix for documentation and upstream fix available in dbatools v2.1.9. + +Bugfixes +-------- + +- Update documentation for agent_job_schedule to reflect proper input formatting. (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) + v2.3.1 ====== diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index def69557..57c71a1e 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -483,3 +483,14 @@ releases: - 2-3-1-release-summary.yml - 231-dbops-v09.yml release_date: '2024-02-24' + 2.3.2: + changes: + bugfixes: + - Update documentation for agent_job_schedule to reflect proper input formatting. + (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) + release_summary: Small fix for documentation and upstream fix available in dbatools + v2.1.9. + fragments: + - 2-3-2-release-summary.yml + - 229-docs-update.yml + release_date: '2024-03-09' diff --git a/galaxy.yml b/galaxy.yml index ee9765b3..ed8ca71c 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -2,7 +2,7 @@ namespace: lowlydba name: sqlserver -version: 2.3.1 +version: 2.3.2 readme: README.md authors: - John McCall (github.com/lowlydba) diff --git a/plugins/modules/agent_job_schedule.py b/plugins/modules/agent_job_schedule.py index 008efca2..cb0232ad 100644 --- a/plugins/modules/agent_job_schedule.py +++ b/plugins/modules/agent_job_schedule.py @@ -80,17 +80,18 @@ start_date: description: - The date on which execution of a job can begin. - - If I(force=true)the start date will be the current day. - - Format is C(YYYY-MM-DD). + - If I(force=true) the start date will be the current day. + - Format is C(yyyyMMdd). type: str required: false end_date: description: - The date on which execution of a job can stop. - - If I(force=true) the end date will be C(9999-12-31). - - Format is C(YYYY-MM-DD). + - If I(force=true) the end date will be C(99991231), via dbatools. + - Format is C(yyyyMMdd). type: str required: false + start_time: description: - The time on any day to begin execution of a job. Format C(HHMMSS) (24 hour clock). diff --git a/tests/integration/targets/agent_job_schedule/tasks/main.yml b/tests/integration/targets/agent_job_schedule/tasks/main.yml index f517b7ed..8f0e367a 100644 --- a/tests/integration/targets/agent_job_schedule/tasks/main.yml +++ b/tests/integration/targets/agent_job_schedule/tasks/main.yml @@ -26,7 +26,6 @@ sql_password: "{{ sqlserver_password }}" start_date: "{{ start_date }}" start_time: "{{ start_time }}" - end_date: "{{ end_date }}" end_time: "{{ end_time }}" frequency_type: "{{ frequency_type }}" frequency_interval: "{{ frequency_interval }}" @@ -46,7 +45,7 @@ - result is changed - result.data.Name == "{{ job_name }}" - - name: Create job schedule with force + - name: Create job schedule with force, no end date lowlydba.sqlserver.agent_job_schedule: schedule: "{{ forced_schedule_name }}" force: true @@ -56,7 +55,7 @@ that: - result.data.ScheduleUid != None - result.data.ActiveStartDate == "3020-05-25T00:00:00.0000000" - - result.data.ActiveEndDate == "3020-05-25T00:00:00.0000000" + - result.data.ActiveEndDate == "9999-12-31T00:00:00.0000000" - result.data.JobCount == 1 - result.data.IsEnabled is true - result.data.ScheduleName == "{{ forced_schedule_name }}"