From 488ef0fc9df652622088318a158236140260d7f8 Mon Sep 17 00:00:00 2001 From: John McCall Date: Sat, 9 Mar 2024 12:42:25 -0500 Subject: [PATCH 01/18] fix: update docs and add test case (#229) * fix: update docs and add test case * fix * chore: release --- CHANGELOG.rst | 13 +++++++++++++ changelogs/changelog.yaml | 11 +++++++++++ galaxy.yml | 2 +- plugins/modules/agent_job_schedule.py | 9 +++++---- .../targets/agent_job_schedule/tasks/main.yml | 5 ++--- 5 files changed, 32 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index f5d5aff0..a9c7adc6 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,19 @@ lowlydba.sqlserver Release Notes .. contents:: Topics +v2.3.2 +====== + +Release Summary +--------------- + +Small fix for documentation and upstream fix available in dbatools v2.1.9. + +Bugfixes +-------- + +- Update documentation for agent_job_schedule to reflect proper input formatting. (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) + v2.3.1 ====== diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index def69557..57c71a1e 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -483,3 +483,14 @@ releases: - 2-3-1-release-summary.yml - 231-dbops-v09.yml release_date: '2024-02-24' + 2.3.2: + changes: + bugfixes: + - Update documentation for agent_job_schedule to reflect proper input formatting. + (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) + release_summary: Small fix for documentation and upstream fix available in dbatools + v2.1.9. + fragments: + - 2-3-2-release-summary.yml + - 229-docs-update.yml + release_date: '2024-03-09' diff --git a/galaxy.yml b/galaxy.yml index ee9765b3..ed8ca71c 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -2,7 +2,7 @@ namespace: lowlydba name: sqlserver -version: 2.3.1 +version: 2.3.2 readme: README.md authors: - John McCall (github.com/lowlydba) diff --git a/plugins/modules/agent_job_schedule.py b/plugins/modules/agent_job_schedule.py index 008efca2..cb0232ad 100644 --- a/plugins/modules/agent_job_schedule.py +++ b/plugins/modules/agent_job_schedule.py @@ -80,17 +80,18 @@ start_date: description: - The date on which execution of a job can begin. - - If I(force=true)the start date will be the current day. - - Format is C(YYYY-MM-DD). + - If I(force=true) the start date will be the current day. + - Format is C(yyyyMMdd). type: str required: false end_date: description: - The date on which execution of a job can stop. - - If I(force=true) the end date will be C(9999-12-31). - - Format is C(YYYY-MM-DD). + - If I(force=true) the end date will be C(99991231), via dbatools. + - Format is C(yyyyMMdd). type: str required: false + start_time: description: - The time on any day to begin execution of a job. Format C(HHMMSS) (24 hour clock). diff --git a/tests/integration/targets/agent_job_schedule/tasks/main.yml b/tests/integration/targets/agent_job_schedule/tasks/main.yml index f517b7ed..8f0e367a 100644 --- a/tests/integration/targets/agent_job_schedule/tasks/main.yml +++ b/tests/integration/targets/agent_job_schedule/tasks/main.yml @@ -26,7 +26,6 @@ sql_password: "{{ sqlserver_password }}" start_date: "{{ start_date }}" start_time: "{{ start_time }}" - end_date: "{{ end_date }}" end_time: "{{ end_time }}" frequency_type: "{{ frequency_type }}" frequency_interval: "{{ frequency_interval }}" @@ -46,7 +45,7 @@ - result is changed - result.data.Name == "{{ job_name }}" - - name: Create job schedule with force + - name: Create job schedule with force, no end date lowlydba.sqlserver.agent_job_schedule: schedule: "{{ forced_schedule_name }}" force: true @@ -56,7 +55,7 @@ that: - result.data.ScheduleUid != None - result.data.ActiveStartDate == "3020-05-25T00:00:00.0000000" - - result.data.ActiveEndDate == "3020-05-25T00:00:00.0000000" + - result.data.ActiveEndDate == "9999-12-31T00:00:00.0000000" - result.data.JobCount == 1 - result.data.IsEnabled is true - result.data.ScheduleName == "{{ forced_schedule_name }}" From 42597d8cf1c2dfd2903436d461db4b3e8c509248 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 16 Mar 2024 13:03:15 -0400 Subject: [PATCH 02/18] Bump softprops/action-gh-release from 2.0.0 to 2.0.4 (#235) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.0.0 to 2.0.4. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](https://github.com/softprops/action-gh-release/compare/v2.0.0...v2.0.4) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 201875bc..0ee7636a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -69,7 +69,7 @@ jobs: - name: Create Release id: create_release - uses: softprops/action-gh-release@v2.0.0 + uses: softprops/action-gh-release@v2.0.4 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From e0cc75109b156e1475b16f4f4af2c522ec03aaaf Mon Sep 17 00:00:00 2001 From: John McCall Date: Sun, 17 Mar 2024 14:09:26 -0400 Subject: [PATCH 03/18] Update FUNDING.yml (#236) --- .github/FUNDING.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml index c235de88..0c6b880f 100644 --- a/.github/FUNDING.yml +++ b/.github/FUNDING.yml @@ -10,4 +10,5 @@ liberapay: # Replace with a single Liberapay username issuehunt: # Replace with a single IssueHunt username otechie: # Replace with a single Otechie username lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry +buy_me_a_coffee: johnmcc custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2'] From 584c853bc417ab8ba54172cb61e3a80dcd2e06e7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 26 Mar 2024 19:02:51 -0400 Subject: [PATCH 04/18] Bump codecov/codecov-action from 4.1.0 to 4.1.1 (#237) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index d764d601..ac621ea6 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.1.0 + - uses: codecov/codecov-action@v4.1.1 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index 242c7a64..ce9cd1f4 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.1.0 + - uses: codecov/codecov-action@v4.1.1 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.1.0 + - uses: codecov/codecov-action@v4.1.1 with: fail_ci_if_error: false From 876ace42132adc30b09bf0dcc7e1917daf941d99 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 6 Apr 2024 11:33:40 -0400 Subject: [PATCH 05/18] Bump codecov/codecov-action from 4.1.1 to 4.2.0 (#238) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.1 to 4.2.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v4.1.1...v4.2.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index ac621ea6..c9832dbb 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.1.1 + - uses: codecov/codecov-action@v4.2.0 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index ce9cd1f4..da344cad 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.1.1 + - uses: codecov/codecov-action@v4.2.0 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.1.1 + - uses: codecov/codecov-action@v4.2.0 with: fail_ci_if_error: false From 7858e47ed09aed732725a99dd98288fd343b5cc2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 13 Apr 2024 10:48:27 -0400 Subject: [PATCH 06/18] Bump codecov/codecov-action from 4.2.0 to 4.3.0 (#240) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v4.2.0...v4.3.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index c9832dbb..5e4ba7c6 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.2.0 + - uses: codecov/codecov-action@v4.3.0 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index da344cad..679685be 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.2.0 + - uses: codecov/codecov-action@v4.3.0 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.2.0 + - uses: codecov/codecov-action@v4.3.0 with: fail_ci_if_error: false From 92fed494848ef2b40e1ca0ba390ba483359cd915 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 13 Apr 2024 10:48:38 -0400 Subject: [PATCH 07/18] Bump ansible-community/ansible-test-gh-action from 1.14.1 to 1.15.0 (#239) Bumps [ansible-community/ansible-test-gh-action](https://github.com/ansible-community/ansible-test-gh-action) from 1.14.1 to 1.15.0. - [Release notes](https://github.com/ansible-community/ansible-test-gh-action/releases) - [Commits](https://github.com/ansible-community/ansible-test-gh-action/compare/v1.14.1...v1.15.0) --- updated-dependencies: - dependency-name: ansible-community/ansible-test-gh-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index 679685be..1ff26feb 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -68,7 +68,7 @@ jobs: path: ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} - name: Run confidence tests - uses: ansible-community/ansible-test-gh-action@v1.14.1 + uses: ansible-community/ansible-test-gh-action@v1.15.0 with: ansible-core-version: ${{ matrix.ansible }} testing-type: sanity @@ -128,7 +128,7 @@ jobs: # Prevent dbatools v2+ issues with newer docker image for 2.13 - name: Run integration tests - v2.13 workaround if: ${{ matrix.ansible == 'stable-2.13' }} - uses: ansible-community/ansible-test-gh-action@v1.14.1 + uses: ansible-community/ansible-test-gh-action@v1.15.0 with: docker-image: 'quay.io/ansible/default-test-container:6.13.0' ansible-core-version: ${{ matrix.ansible }} @@ -139,7 +139,7 @@ jobs: - name: Run integration tests if: ${{ matrix.ansible != 'stable-2.13'}} - uses: ansible-community/ansible-test-gh-action@v1.14.1 + uses: ansible-community/ansible-test-gh-action@v1.15.0 with: ansible-core-version: ${{ matrix.ansible }} #target-python-version: ${{ matrix.python }} From 720db7e2702c794c5bb276a838a7765661919f6c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 4 May 2024 09:48:49 -0400 Subject: [PATCH 08/18] build(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (#241) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index 5e4ba7c6..7c4dbc9b 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.3.0 + - uses: codecov/codecov-action@v4.3.1 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index 1ff26feb..9705650a 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.3.0 + - uses: codecov/codecov-action@v4.3.1 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.3.0 + - uses: codecov/codecov-action@v4.3.1 with: fail_ci_if_error: false From 3d2df7996688b02d0445e896c1dbfff0fd917750 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 17 May 2024 17:54:43 -0400 Subject: [PATCH 09/18] build(deps): bump softprops/action-gh-release from 2.0.4 to 2.0.5 (#244) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.0.4 to 2.0.5. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](https://github.com/softprops/action-gh-release/compare/v2.0.4...v2.0.5) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0ee7636a..9b40638f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -69,7 +69,7 @@ jobs: - name: Create Release id: create_release - uses: softprops/action-gh-release@v2.0.4 + uses: softprops/action-gh-release@v2.0.5 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From 8f8dbe65ef7c405f3301676cd104003f040f8fdb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 17 May 2024 17:59:09 -0400 Subject: [PATCH 10/18] build(deps): bump codecov/codecov-action from 4.3.1 to 4.4.0 (#247) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.1 to 4.4.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index 7c4dbc9b..4c736a3e 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.3.1 + - uses: codecov/codecov-action@v4.4.0 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index 9705650a..c0576a9d 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.3.1 + - uses: codecov/codecov-action@v4.4.0 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.3.1 + - uses: codecov/codecov-action@v4.4.0 with: fail_ci_if_error: false From de0aac7ce6c91379d2e2114bb55f35b41a3e9e49 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 22 May 2024 16:50:02 -0400 Subject: [PATCH 11/18] --- (#248) updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index 4c736a3e..8de2ad07 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.4.0 + - uses: codecov/codecov-action@v4.4.1 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index c0576a9d..667ab3b2 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.4.0 + - uses: codecov/codecov-action@v4.4.1 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.4.0 + - uses: codecov/codecov-action@v4.4.1 with: fail_ci_if_error: false From 01a181263f00c33965f89b11e84ad97537a03a54 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 2 Jun 2024 15:29:55 -0400 Subject: [PATCH 12/18] build(deps): bump Vampire/setup-wsl from 3.0.0 to 3.1.1 (#252) Bumps [Vampire/setup-wsl](https://github.com/vampire/setup-wsl) from 3.0.0 to 3.1.1. - [Release notes](https://github.com/vampire/setup-wsl/releases) - [Commits](https://github.com/vampire/setup-wsl/compare/v3.0.0...v3.1.1) --- updated-dependencies: - dependency-name: Vampire/setup-wsl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index 8de2ad07..a75026a8 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -104,7 +104,7 @@ jobs: shell: cmd run: echo 127.0.0.1 sqlserver >> "%WinDir%\System32\Drivers\etc\hosts" - - uses: Vampire/setup-wsl@v3.0.0 + - uses: Vampire/setup-wsl@v3.1.1 with: distribution: Ubuntu-22.04 update: "true" From 851203195854795452b754a23d26e58d75d790d9 Mon Sep 17 00:00:00 2001 From: daarrn <60488826+daarrn@users.noreply.github.com> Date: Thu, 6 Jun 2024 16:54:08 -0600 Subject: [PATCH 13/18] changing ip_address param to expect list (#246) * changing ip_address param to expect list * 1) changing all list expecting params to be typed as list and including element type 2) updated fragment to be inclusive of all changes * updating documented options to match * spaces for pslint satisfaction * updated tests file to use lists for list type parameters * updated code examples to show passing in lists instead of single or comma separated strings --------- Co-authored-by: John McCall --- .../245-ag_listener-ip_address-fix.yml | 2 ++ plugins/modules/ag_listener.ps1 | 6 +++--- plugins/modules/ag_listener.py | 19 +++++++++++++------ plugins/modules/spn.py | 10 +++++++--- .../targets/win_ag_listener/tasks/main.yml | 6 ++++-- 5 files changed, 29 insertions(+), 14 deletions(-) create mode 100644 changelogs/fragments/245-ag_listener-ip_address-fix.yml diff --git a/changelogs/fragments/245-ag_listener-ip_address-fix.yml b/changelogs/fragments/245-ag_listener-ip_address-fix.yml new file mode 100644 index 00000000..4c4e99f2 --- /dev/null +++ b/changelogs/fragments/245-ag_listener-ip_address-fix.yml @@ -0,0 +1,2 @@ +bugfixes: + - fixed the expected type of the ip_address, subnet_ip, and subnet_mask parameters to be lists instead of strings (lowlydba.sqlserver.ag_listener) diff --git a/plugins/modules/ag_listener.ps1 b/plugins/modules/ag_listener.ps1 index e20238ed..21cc0553 100644 --- a/plugins/modules/ag_listener.ps1 +++ b/plugins/modules/ag_listener.ps1 @@ -15,9 +15,9 @@ $spec = @{ options = @{ ag_name = @{type = 'str'; required = $true } listener_name = @{type = 'str'; required = $true } - ip_address = @{type = 'str'; required = $false } - subnet_ip = @{type = 'str'; required = $false } - subnet_mask = @{type = 'str'; required = $false; default = '255.255.255.0' } + ip_address = @{type = 'list'; elements = 'str'; required = $false } + subnet_ip = @{type = 'list'; elements = 'str'; required = $false } + subnet_mask = @{type = 'list'; elements = 'str'; required = $false; default = '255.255.255.0' } port = @{type = 'int'; required = $false; default = 1433 } dhcp = @{type = 'bool'; required = $false; default = $false } state = @{type = "str"; required = $false; default = "present"; choices = @("present", "absent") } diff --git a/plugins/modules/ag_listener.py b/plugins/modules/ag_listener.py index 12f0ec63..e835678a 100644 --- a/plugins/modules/ag_listener.py +++ b/plugins/modules/ag_listener.py @@ -25,17 +25,20 @@ ip_address: description: - IP address(es) of the listener. Comma separated if multiple. - type: str + type: list + elements: str required: false subnet_ip: description: - Subnet IP address(es) of the listener. Comma separated if multiple. - type: str + type: list + elements: str required: false subnet_mask: description: - Sets the subnet IP mask(s) of the availability group listener. Comma separated if multiple. - type: str + type: list + elements: str required: false default: 255.255.255.0 port: @@ -71,9 +74,13 @@ sql_instance_primary: sql-01.myco.io ag_name: AG_MyDatabase listener_name: aglMyDatabase - ip_address: 10.0.20.20,10.1.77.77 - subnet_ip: 255.255.252.0 - subnet_mask: 255.255.255.0 + ip_address: + - 10.0.20.20 + - 10.1.77.77 + subnet_ip: + - 255.255.252.0 + subnet_mask: + - 255.255.255.0 ''' RETURN = r''' diff --git a/plugins/modules/spn.py b/plugins/modules/spn.py index 0fabb934..d08d825b 100644 --- a/plugins/modules/spn.py +++ b/plugins/modules/spn.py @@ -52,9 +52,13 @@ sql_instance_primary: sql-01.myco.io ag_name: AG_MyDatabase listener_name: aglMyDatabase - ip_address: 10.0.20.20,10.1.77.77 - subnet_ip: 255.255.252.0 - subnet_mask: 255.255.255.0 + ip_address: + - 10.0.20.20 + - 10.1.77.77 + subnet_ip: + - 255.255.252.0 + subnet_mask: + - 255.255.255.0 - name: Add SPN for new AG listener on port 1433 lowlydba.sqlserver.spn: diff --git a/tests/integration/targets/win_ag_listener/tasks/main.yml b/tests/integration/targets/win_ag_listener/tasks/main.yml index b4142a48..68604997 100644 --- a/tests/integration/targets/win_ag_listener/tasks/main.yml +++ b/tests/integration/targets/win_ag_listener/tasks/main.yml @@ -25,8 +25,10 @@ ag_name: "{{ ag_name }}" listener_name: "{{ listener_name }}" port: "{{ port }}" - ip_address: "192.168.6.9" - subnet_mask: "255.255.255.0" + ip_address: + - "192.168.6.9" + subnet_mask: + - "255.255.255.0" tags: ["ag_listener"] block: - name: Enable hadr From b1cb5049e0308d879a2c30a46a87229140e1d945 Mon Sep 17 00:00:00 2001 From: John McCall Date: Thu, 6 Jun 2024 19:07:12 -0400 Subject: [PATCH 14/18] chore: bump to v2.3.3 (#253) --- CHANGELOG.rst | 12 ++++++++++++ changelogs/changelog.yaml | 11 +++++++++++ .../fragments/245-ag_listener-ip_address-fix.yml | 2 -- galaxy.yml | 2 +- 4 files changed, 24 insertions(+), 3 deletions(-) delete mode 100644 changelogs/fragments/245-ag_listener-ip_address-fix.yml diff --git a/CHANGELOG.rst b/CHANGELOG.rst index a9c7adc6..502fe9b8 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -4,6 +4,18 @@ lowlydba.sqlserver Release Notes .. contents:: Topics +v2.3.3 +====== + +Release Summary +--------------- + +Minor bugfix for ag listener input types, thanks @daarrn for the contribution! + +Bugfixes +-------- + +- fixed the expected type of the ip_address, subnet_ip, and subnet_mask parameters to be lists instead of strings (lowlydba.sqlserver.ag_listener) v2.3.2 ====== diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 57c71a1e..a8a45ded 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -494,3 +494,14 @@ releases: - 2-3-2-release-summary.yml - 229-docs-update.yml release_date: '2024-03-09' + 2.3.3: + changes: + bugfixes: + - fixed the expected type of the ip_address, subnet_ip, and subnet_mask parameters + to be lists instead of strings (lowlydba.sqlserver.ag_listener) + release_summary: Minor bugfix for ag listener input types, thanks @daarrn for + the contribution! + fragments: + - 2-3-3-release-summary.yml + - 245-ag_listener-ip_address-fix.yml + release_date: '2024-06-06' diff --git a/changelogs/fragments/245-ag_listener-ip_address-fix.yml b/changelogs/fragments/245-ag_listener-ip_address-fix.yml deleted file mode 100644 index 4c4e99f2..00000000 --- a/changelogs/fragments/245-ag_listener-ip_address-fix.yml +++ /dev/null @@ -1,2 +0,0 @@ -bugfixes: - - fixed the expected type of the ip_address, subnet_ip, and subnet_mask parameters to be lists instead of strings (lowlydba.sqlserver.ag_listener) diff --git a/galaxy.yml b/galaxy.yml index ed8ca71c..dd7ab08d 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -2,7 +2,7 @@ namespace: lowlydba name: sqlserver -version: 2.3.2 +version: 2.3.3 readme: README.md authors: - John McCall (github.com/lowlydba) From 6575d054641922ea880e9b5db2fd9a07dad262a7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 14 Jun 2024 13:20:40 -0400 Subject: [PATCH 15/18] build(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 (#254) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.4.1 to 4.5.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v4.4.1...v4.5.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index a75026a8..cc7a886c 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -190,6 +190,6 @@ jobs: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.4.1 + - uses: codecov/codecov-action@v4.5.0 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index 667ab3b2..f63a8db9 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -79,7 +79,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.4.1 + - uses: codecov/codecov-action@v4.5.0 with: fail_ci_if_error: false @@ -153,6 +153,6 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@v4.4.1 + - uses: codecov/codecov-action@v4.5.0 with: fail_ci_if_error: false From c8ec17ab5711209d1e20a2fa4c183464baee4e75 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 19 Jun 2024 23:10:04 -0400 Subject: [PATCH 16/18] build(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.6 (#255) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.0.5 to 2.0.6. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](https://github.com/softprops/action-gh-release/compare/v2.0.5...v2.0.6) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9b40638f..aa91fccd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -69,7 +69,7 @@ jobs: - name: Create Release id: create_release - uses: softprops/action-gh-release@v2.0.5 + uses: softprops/action-gh-release@v2.0.6 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From 655394d6ac4e89751b9da33ec1f198237cbd4405 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 23 Jul 2024 19:06:02 -0400 Subject: [PATCH 17/18] build(deps): bump softprops/action-gh-release from 2.0.6 to 2.0.8 (#259) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.0.6 to 2.0.8. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](https://github.com/softprops/action-gh-release/compare/v2.0.6...v2.0.8) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index aa91fccd..33773fb9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -69,7 +69,7 @@ jobs: - name: Create Release id: create_release - uses: softprops/action-gh-release@v2.0.6 + uses: softprops/action-gh-release@v2.0.8 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From 5075c389161fe0edb3a8a618a22adfb7b459609d Mon Sep 17 00:00:00 2001 From: John McCall Date: Sat, 7 Sep 2024 14:08:56 -0400 Subject: [PATCH 18/18] chore: use newer python for dlevel (#257) * chore: use newer python for dlevel * chore: fix python version * chore: tweak python again * chore: update ubuntu wsl version * Update .github/workflows/ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Revert "Update ansible-test-windows.yml" This reverts commit a4061b7b81333c4241762ee3bc89b813591d4d32. * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml * Update ansible-test-windows.yml --- .github/workflows/ansible-test-windows.yml | 24 ++++++++-------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index cc7a886c..56c53726 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -46,28 +46,18 @@ jobs: matrix: os: - windows-2022 + wsl: + - Ubuntu-24.04 ansible: - - stable-2.13 - - stable-2.14 - - stable-2.15 - stable-2.16 + - stable-2.17 - devel python: - python3 - - python3.10 group: # windows/group/#/ - "1" - "2" #- '3' - exclude: - - ansible: stable-2.13 - python: python3.10 - - ansible: stable-2.14 - python: python3.10 - - ansible: stable-2.15 - python: python3.10 - - ansible: devel - python: python3 defaults: run: shell: wsl-bash {0} @@ -106,8 +96,8 @@ jobs: - uses: Vampire/setup-wsl@v3.1.1 with: - distribution: Ubuntu-22.04 - update: "true" + distribution: ${{ matrix.wsl }} + update: "false" use-cache: "true" additional-packages: | git @@ -141,9 +131,11 @@ jobs: $ws = ConvertTo-LinuxPathCrappy -LiteralPath "${{ github.workspace }}" Add-Content -LiteralPath $env:GITHUB_ENV -Value "GHWS=$ws" + # Override break-sys-pkg defaults, because we don't need to bother with python venv for CI - name: Install ansible-base (${{ matrix.ansible }}) run: | - ${{ matrix.python }} -m pip install --upgrade pip setuptools pypsrp --disable-pip-version-check --retries 10 + ${{ matrix.python }} -m pip config set global.break-system-packages true + ${{ matrix.python }} -m pip install --upgrade setuptools pypsrp --disable-pip-version-check --retries 10 ${{ matrix.python }} -m pip install https://github.com/ansible/ansible/archive/${{ matrix.ansible }}.tar.gz --disable-pip-version-check --retries 10 - name: Install collection dependencies