From 21c2d568b24efb67cb80f54610c0303e0ee42ed7 Mon Sep 17 00:00:00 2001 From: John McCall Date: Fri, 23 Feb 2024 15:09:50 -0500 Subject: [PATCH 1/5] fix: update docs and add test case --- plugins/modules/agent_job_schedule.py | 7 ++++--- .../integration/targets/agent_job_schedule/tasks/main.yml | 5 ++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/plugins/modules/agent_job_schedule.py b/plugins/modules/agent_job_schedule.py index 008efca2..1ac8457c 100644 --- a/plugins/modules/agent_job_schedule.py +++ b/plugins/modules/agent_job_schedule.py @@ -81,16 +81,17 @@ description: - The date on which execution of a job can begin. - If I(force=true)the start date will be the current day. - - Format is C(YYYY-MM-DD). + - Format is C(yyyyMMdd). type: str required: false end_date: description: - The date on which execution of a job can stop. - - If I(force=true) the end date will be C(9999-12-31). - - Format is C(YYYY-MM-DD). + - If I(force=true) the end date will be C(99991231), via dbatools. + - Format is C(yyyyMMdd). type: str required: false + start_time: description: - The time on any day to begin execution of a job. Format C(HHMMSS) (24 hour clock). diff --git a/tests/integration/targets/agent_job_schedule/tasks/main.yml b/tests/integration/targets/agent_job_schedule/tasks/main.yml index f517b7ed..1655ffd5 100644 --- a/tests/integration/targets/agent_job_schedule/tasks/main.yml +++ b/tests/integration/targets/agent_job_schedule/tasks/main.yml @@ -10,7 +10,6 @@ frequency_subday_type: "Hours" frequency_subday_interval: 5 frequency_relative_interval: "First" - end_date: "30200525" end_time: "000929" start_date_result: "3020-05-25T00:00:00" end_date_result: "3020-05-25T00:00:00" @@ -46,7 +45,7 @@ - result is changed - result.data.Name == "{{ job_name }}" - - name: Create job schedule with force + - name: Create job schedule with force, no end date lowlydba.sqlserver.agent_job_schedule: schedule: "{{ forced_schedule_name }}" force: true @@ -56,7 +55,7 @@ that: - result.data.ScheduleUid != None - result.data.ActiveStartDate == "3020-05-25T00:00:00.0000000" - - result.data.ActiveEndDate == "3020-05-25T00:00:00.0000000" + - result.data.ActiveEndDate == "9999-12-31T00:00:00.0000000" - result.data.JobCount == 1 - result.data.IsEnabled is true - result.data.ScheduleName == "{{ forced_schedule_name }}" From 6d1aec4922841f2550c1d3a786ae168b272f498c Mon Sep 17 00:00:00 2001 From: John McCall Date: Fri, 23 Feb 2024 15:27:25 -0500 Subject: [PATCH 2/5] fix --- plugins/modules/agent_job_schedule.py | 2 +- tests/integration/targets/agent_job_schedule/tasks/main.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/modules/agent_job_schedule.py b/plugins/modules/agent_job_schedule.py index 1ac8457c..cb0232ad 100644 --- a/plugins/modules/agent_job_schedule.py +++ b/plugins/modules/agent_job_schedule.py @@ -80,7 +80,7 @@ start_date: description: - The date on which execution of a job can begin. - - If I(force=true)the start date will be the current day. + - If I(force=true) the start date will be the current day. - Format is C(yyyyMMdd). type: str required: false diff --git a/tests/integration/targets/agent_job_schedule/tasks/main.yml b/tests/integration/targets/agent_job_schedule/tasks/main.yml index 1655ffd5..8f0e367a 100644 --- a/tests/integration/targets/agent_job_schedule/tasks/main.yml +++ b/tests/integration/targets/agent_job_schedule/tasks/main.yml @@ -10,6 +10,7 @@ frequency_subday_type: "Hours" frequency_subday_interval: 5 frequency_relative_interval: "First" + end_date: "30200525" end_time: "000929" start_date_result: "3020-05-25T00:00:00" end_date_result: "3020-05-25T00:00:00" @@ -25,7 +26,6 @@ sql_password: "{{ sqlserver_password }}" start_date: "{{ start_date }}" start_time: "{{ start_time }}" - end_date: "{{ end_date }}" end_time: "{{ end_time }}" frequency_type: "{{ frequency_type }}" frequency_interval: "{{ frequency_interval }}" From b9cc95a36dcd786710f51ca262da1f7cf7613d15 Mon Sep 17 00:00:00 2001 From: John McCall Date: Sat, 9 Mar 2024 12:42:13 -0500 Subject: [PATCH 3/5] chore: release --- CHANGELOG.rst | 13 +++++++++++++ changelogs/changelog.yaml | 11 +++++++++++ galaxy.yml | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index f5d5aff0..a9c7adc6 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,19 @@ lowlydba.sqlserver Release Notes .. contents:: Topics +v2.3.2 +====== + +Release Summary +--------------- + +Small fix for documentation and upstream fix available in dbatools v2.1.9. + +Bugfixes +-------- + +- Update documentation for agent_job_schedule to reflect proper input formatting. (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) + v2.3.1 ====== diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index def69557..57c71a1e 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -483,3 +483,14 @@ releases: - 2-3-1-release-summary.yml - 231-dbops-v09.yml release_date: '2024-02-24' + 2.3.2: + changes: + bugfixes: + - Update documentation for agent_job_schedule to reflect proper input formatting. + (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) + release_summary: Small fix for documentation and upstream fix available in dbatools + v2.1.9. + fragments: + - 2-3-2-release-summary.yml + - 229-docs-update.yml + release_date: '2024-03-09' diff --git a/galaxy.yml b/galaxy.yml index ee9765b3..ed8ca71c 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -2,7 +2,7 @@ namespace: lowlydba name: sqlserver -version: 2.3.1 +version: 2.3.2 readme: README.md authors: - John McCall (github.com/lowlydba) From 79028a13cb213600bc2881e7446eb91bd3cbaeff Mon Sep 17 00:00:00 2001 From: John McCall Date: Sat, 7 Sep 2024 14:13:05 -0400 Subject: [PATCH 4/5] chore(ci): fix perms for docs build --- .github/workflows/docs-pr.yml | 4 ++++ .github/workflows/docs-push.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/docs-pr.yml b/.github/workflows/docs-pr.yml index 7bfe7c53..aeb7f833 100644 --- a/.github/workflows/docs-pr.yml +++ b/.github/workflows/docs-pr.yml @@ -9,6 +9,10 @@ on: env: GHP_BASE_URL: https://${{ github.repository_owner }}.github.io/${{ github.event.repository.name }} +permissions: + pages: write + id-token: write + jobs: validate-docs: permissions: diff --git a/.github/workflows/docs-push.yml b/.github/workflows/docs-push.yml index 3a152d0c..c30d1835 100644 --- a/.github/workflows/docs-push.yml +++ b/.github/workflows/docs-push.yml @@ -11,6 +11,10 @@ on: schedule: - cron: '0 13 * * *' +permissions: + pages: write + id-token: write + jobs: build-docs: permissions: From 9f045a0bd8346a7b6c4a629b5bfb1270d18b4552 Mon Sep 17 00:00:00 2001 From: John McCall Date: Sat, 7 Sep 2024 14:15:23 -0400 Subject: [PATCH 5/5] Update CHANGELOG.rst --- CHANGELOG.rst | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index fa412ffc..502fe9b8 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -30,19 +30,6 @@ Bugfixes - Update documentation for agent_job_schedule to reflect proper input formatting. (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) -v2.3.2 -====== - -Release Summary ---------------- - -Small fix for documentation and upstream fix available in dbatools v2.1.9. - -Bugfixes --------- - -- Update documentation for agent_job_schedule to reflect proper input formatting. (https://github.com/lowlydba/lowlydba.sqlserver/pull/229) - v2.3.1 ======